From 4a7c9dbf9a42330970a9742c1d476f2a9075f3f9 Mon Sep 17 00:00:00 2001 From: Rasmus Villemoes Date: Wed, 11 May 2022 16:12:50 +0200 Subject: [PATCH] net: dwc_eth_qos: fix double resource leak in eqos_remove() Not only does eqos_remove() fail to free the buffers that have been allocated by eqos_probe_resources_core(), it repeats those allocations and thus drops twice as much memory on the floor. Signed-off-by: Rasmus Villemoes Reviewed-by: Ramon Fried --- drivers/net/dwc_eth_qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index c1f2391..7c504dd 100644 --- a/drivers/net/dwc_eth_qos.c +++ b/drivers/net/dwc_eth_qos.c @@ -1574,7 +1574,7 @@ static int eqos_remove(struct udevice *dev) eqos->config->ops->eqos_stop_clks(dev); eqos->config->ops->eqos_remove_resources(dev); - eqos_probe_resources_core(dev); + eqos_remove_resources_core(dev); debug("%s: OK\n", __func__); return 0; -- 2.7.4