From 4a697a91de40023535a9f62b997b7b81f4693140 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar <jpienaar@google.com>
Date: Wed, 29 May 2019 21:15:43 -0700
Subject: [PATCH]     Fix 5 ClangTidy - Readability findings.

    * the 'empty' method should be used to check for emptiness instead of 'size'
    * using decl 'CapturableHandle' is unused
    * redundant get() call on smart pointer
    * using decl 'apply' is unused
    * using decl 'ScopeGuard' is unused

--

PiperOrigin-RevId: 250623863
---
 mlir/bindings/python/pybind.cpp             | 2 +-
 mlir/examples/Linalg/Linalg1/lib/Common.cpp | 1 -
 mlir/include/mlir/IR/MLIRContext.h          | 2 +-
 mlir/lib/Transforms/Vectorize.cpp           | 2 --
 4 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/mlir/bindings/python/pybind.cpp b/mlir/bindings/python/pybind.cpp
index 3dd4d92..76cec27 100644
--- a/mlir/bindings/python/pybind.cpp
+++ b/mlir/bindings/python/pybind.cpp
@@ -482,7 +482,7 @@ struct PythonAttributedType {
     std::string res;
     llvm::raw_string_ostream os(res);
     t.print(os);
-    if (attrs.size() == 0)
+    if (attrs.empty())
       return os.str();
 
     os << '{';
diff --git a/mlir/examples/Linalg/Linalg1/lib/Common.cpp b/mlir/examples/Linalg/Linalg1/lib/Common.cpp
index a192e2e..9ce6613 100644
--- a/mlir/examples/Linalg/Linalg1/lib/Common.cpp
+++ b/mlir/examples/Linalg/Linalg1/lib/Common.cpp
@@ -28,7 +28,6 @@
 
 using llvm::ArrayRef;
 using mlir::ConstantIndexOp;
-using mlir::edsc::CapturableHandle;
 using mlir::edsc::ValueHandle;
 using mlir::edsc::intrinsics::alloc;
 using mlir::edsc::intrinsics::ret;
diff --git a/mlir/include/mlir/IR/MLIRContext.h b/mlir/include/mlir/IR/MLIRContext.h
index 864fd96..48e9e03 100644
--- a/mlir/include/mlir/IR/MLIRContext.h
+++ b/mlir/include/mlir/IR/MLIRContext.h
@@ -65,7 +65,7 @@ public:
 
   // This is effectively private given that only MLIRContext.cpp can see the
   // MLIRContextImpl type.
-  MLIRContextImpl &getImpl() { return *impl.get(); }
+  MLIRContextImpl &getImpl() { return *impl; }
 
   /// Emit an error message using the diagnostic engine.
   InFlightDiagnostic emitError(Location location);
diff --git a/mlir/lib/Transforms/Vectorize.cpp b/mlir/lib/Transforms/Vectorize.cpp
index 4b66a77..ddaf112 100644
--- a/mlir/lib/Transforms/Vectorize.cpp
+++ b/mlir/lib/Transforms/Vectorize.cpp
@@ -537,10 +537,8 @@ using namespace mlir;
 
 #define DEBUG_TYPE "early-vect"
 
-using functional::apply;
 using functional::makePtrDynCaster;
 using functional::map;
-using functional::ScopeGuard;
 using llvm::dbgs;
 using llvm::DenseSet;
 using llvm::SetVector;
-- 
2.7.4