From 4a4e64d6c7f9ddb909125de68956dde9b16e57fe Mon Sep 17 00:00:00 2001 From: "svenpanne@chromium.org" Date: Tue, 4 Feb 2014 08:30:35 +0000 Subject: [PATCH] Dispose Isolate at end of cctest. No measurable change in test running time, we clean up only trivial known things at disposal time and do not walk the heap, run real finalizers, etc. R=ulan@chromium.org Review URL: https://codereview.chromium.org/135153007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19047 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/cctest/cctest.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h index 6c67dd5..d9f7629 100644 --- a/test/cctest/cctest.h +++ b/test/cctest/cctest.h @@ -131,8 +131,7 @@ class CcTest { v8::Isolate* isolate = CcTest::isolate()); static void TearDown() { - // TODO(svenpanne) Enable this when our cctests are fixed. - // if (isolate_ != NULL) isolate_->Dispose(); + if (isolate_ != NULL) isolate_->Dispose(); } private: -- 2.7.4