From 49bd3b45383f5bbec9dc150b034c034afea664c1 Mon Sep 17 00:00:00 2001 From: "he.he" Date: Thu, 5 Sep 2019 05:21:34 -0400 Subject: [PATCH] usb: CtsVerifier.apk usb device test failed [1/1] PD#SWPL-13498 Problem: The printing may delay the usb_disconnect processing, result to USB transfer error during reconnecting. Solution: Moving the print in proc_setconfig of devio.c . Verify: test pass on sm1 Change-Id: I5c45abb2d5d640e2e02dc3e0c08b10ca7a294eeb Signed-off-by: he.he --- drivers/usb/core/devio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 893ebae..46b4b66 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -1388,6 +1388,10 @@ static int proc_setconfig(struct usb_dev_state *ps, void __user *arg) for (i = 0; i < actconfig->desc.bNumInterfaces; ++i) { if (usb_interface_claimed(actconfig->interface[i])) { + /*This print could cause usb cts test fail,since it could + *delay the interrupt of the hub_event for usb_disconnect. + */ +#ifndef CONFIG_AMLOGIC_USB dev_warn(&ps->dev->dev, "usbfs: interface %d claimed by %s " "while '%s' sets config #%d\n", @@ -1397,6 +1401,7 @@ static int proc_setconfig(struct usb_dev_state *ps, void __user *arg) actconfig->interface[i] ->dev.driver->name, current->comm, u); +#endif status = -EBUSY; break; } -- 2.7.4