From 49980807617882448de70647bad3a990a0d07a35 Mon Sep 17 00:00:00 2001
From: "dglazkov@chromium.org"
 <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Tue, 27 Sep 2011 06:32:10 +0000
Subject: [PATCH] garden-o-matic's commit data on summary page should not crowd
 itself or twitch when hovered over.
 https://bugs.webkit.org/show_bug.cgi?id=68864

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 .../TestFailures/scripts/summary-mock.js           |  2 +-
 .../TestFailures/scripts/ui/notifications.js       | 11 ++++----
 .../scripts/ui/notifications_unittests.js          | 32 ++++++++++++++--------
 .../TestFailures/styles/notifications.css          | 22 +++++++++------
 Tools/ChangeLog                                    | 12 ++++++++
 5 files changed, 53 insertions(+), 26 deletions(-)

diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js
index 189de1c..f2d78c4 100644
--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js
+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js
@@ -123,7 +123,7 @@ function createFailingTestsSummary(commitDataCount, failureAnalysisCount, builde
         failingTestsSummary.addCommitData({
             time: minutesAgo(currentMinutesAgo++),
             revision: currentRevision++,
-            title: bugTitles.cycle(),
+            summary: bugTitles.cycle(),
             author: people.cycle(),
             reviewer: people.cycle()
         });
diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
index df2bf0a..87c5375 100644
--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
@@ -108,24 +108,25 @@ ui.notifications.SuspiciousCommit = base.extends(Cause, {
     {
         this._revision = commitData.revision;
         var linkToRevision = this._description.appendChild(document.createElement('a'));
+        this._details = this._description.appendChild(document.createElement('span'));
         linkToRevision.href = trac.changesetURL(commitData.revision);
         linkToRevision.target = '_blank';
         linkToRevision.textContent = commitData.revision;
-        this._addDescriptionPart('summary', commitData);
-        this._addDescriptionPart('author', commitData);
-        this._addDescriptionPart('reviewer', commitData);
+        this._addDetail('summary', commitData);
+        this._addDetail('author', commitData);
+        this._addDetail('reviewer', commitData);
     },
     hasRevision: function(revision)
     {
         return this._revision == revision;
     },
-    _addDescriptionPart: function(part, commitData)
+    _addDetail: function(part, commitData)
     {
         var content = commitData[part];
         if (!content)
             return;
 
-        var span = this._description.appendChild(document.createElement('span'));
+        var span = this._details.appendChild(document.createElement('span'));
         span.className = part;
         span.textContent = content;
     }
diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
index d677115..86bc82f 100644
--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
@@ -88,9 +88,11 @@ test('SuspiciousCommit', 2, function() {
     equal(suspiciousCommit.innerHTML,
         '<div class="description">' +
             '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' +
-            '<span class="summary">summary</span>' +
-            '<span class="author">author</span>' +
-            '<span class="reviewer">reviewer</span>' +
+            '<span>' +
+                '<span class="summary">summary</span>' +
+                '<span class="author">author</span>' +
+                '<span class="reviewer">reviewer</span>' +
+            '</span>' +
         '</div>' +
         '<ul class="actions">' +
             '<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
@@ -195,9 +197,11 @@ test('FailingTestsSummary', 12, function() {
                 '<li>' +
                     '<div class="description">' +
                         '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' +
-                        '<span class="summary">summary</span>' +
-                        '<span class="author">author</span>' +
-                        '<span class="reviewer">reviewer</span>' +
+                        '<span>' +
+                            '<span class="summary">summary</span>' +
+                            '<span class="author">author</span>' +
+                            '<span class="reviewer">reviewer</span>' +
+                        '</span>' +
                     '</div>' +
                     '<ul class="actions">' +
                         '<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
@@ -239,9 +243,11 @@ test('FailingTestsSummary', 12, function() {
                 '<li>' +
                     '<div class="description">' +
                         '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' +
-                        '<span class="summary">summary</span>' +
-                        '<span class="author">author</span>' +
-                        '<span class="reviewer">reviewer</span>' +
+                        '<span>' +
+                            '<span class="summary">summary</span>' +
+                            '<span class="author">author</span>' +
+                            '<span class="reviewer">reviewer</span>' +
+                        '</span>' +
                     '</div>' +
                     '<ul class="actions">' +
                         '<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
@@ -287,9 +293,11 @@ test('FailingTestsSummary', 12, function() {
                 '<li>' +
                     '<div class="description">' +
                         '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' +
-                        '<span class="summary">summary</span>' +
-                        '<span class="author">author</span>' +
-                        '<span class="reviewer">reviewer</span>' +
+                        '<span>' +
+                            '<span class="summary">summary</span>' +
+                            '<span class="author">author</span>' +
+                            '<span class="reviewer">reviewer</span>' +
+                        '</span>' +
                     '</div>' +
                     '<ul class="actions">' +
                         '<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css
index 7bd2bfc..49cfdc4 100644
--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css
+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css
@@ -100,7 +100,8 @@ ol.notifications>li ul.causes>li>ul.actions {
 }
 
     ol.notifications>li ul.causes>li>div.description {
-        padding: 0 10px 0 0;
+        padding: 0 10px 5px 0;
+        display: -webkit-box;
     }
 
         ol.notifications>li ul.causes>li>div.description>a {
@@ -111,8 +112,9 @@ ol.notifications>li ul.causes>li>ul.actions {
         ol.notifications>li ul.causes>li:hover>div.description>a {
             background-color: #555;
             padding: 5px 10px 5px 10px;
-            margin: 0 10px 0 0;
+            margin: -5px 10px -1px 0;
             color: White;
+            display: inline-block;
         }
 
         ol.notifications>li ul.causes>li:hover>div.description>a::after {
@@ -129,22 +131,26 @@ ol.notifications>li ul.causes>li>ul.actions {
 
         ol.notifications>li ul.causes>li>div.description>span {
             padding: 0 10px 0 0;
-            display: inline-block;
+            display: block;
+            cursor: default;
+            pointer-events: none;
+            -webkit-box-flex: 1;
         }
 
-        ol.notifications>li ul.causes>li>div.description>span.author {
+        ol.notifications>li ul.causes>li>div.description>span>span.author {
+            padding: 0 0 0 5px;
             font-style: italic;
         }
 
-        ol.notifications>li ul.causes>li>div.description>span.reviewer {
+        ol.notifications>li ul.causes>li>div.description>span>span.reviewer {
             color: Gray;
         }
 
-        ol.notifications>li ul.causes>li>div.description>span.reviewer::before {
-            content: '(';
+        ol.notifications>li ul.causes>li>div.description>span>span.reviewer::before {
+            content: ' (';
         }
 
-        ol.notifications>li ul.causes>li>div.description>span.reviewer::after {
+        ol.notifications>li ul.causes>li>div.description>span>span.reviewer::after {
             content: ')';
         }
 
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 1357fd0..1c2184e 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,15 @@
+2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
+        https://bugs.webkit.org/show_bug.cgi?id=68864
+
+        Reviewed by Adam Barth.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
+
 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
 
         [Qt][WK2] One more unreviewed buildfix after r96005.
-- 
2.7.4