From 498620d16c8661d216c45694622c540cfb838b90 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 28 Sep 2010 16:14:14 +0200 Subject: [PATCH] frei0r: Fix crashes if plugins don't provide correct property information MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The vertigo plugin for example claims to have 3 properties but the 3rd property does nothing and has a NULL name. Fixes bug #630783. Thanks to Martti Kühne for debugging this. --- gst/frei0r/gstfrei0r.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gst/frei0r/gstfrei0r.c b/gst/frei0r/gstfrei0r.c index 2254dc2..6b8c008 100644 --- a/gst/frei0r/gstfrei0r.c +++ b/gst/frei0r/gstfrei0r.c @@ -72,6 +72,12 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class, ftable->get_param_info (param_info, i); + if (!param_info->name) { + GST_ERROR ("Property %d of %s without a valid name", i, + g_type_name (G_TYPE_FROM_CLASS (gobject_class))); + continue; + } + prop_name = g_ascii_strdown (param_info->name, -1); g_strcanon (prop_name, G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "-+", '-'); /* satisfy glib2 (argname[0] must be [A-Za-z]) */ -- 2.7.4