From 49740e02555f72394fb319a8221bad833d8207db Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Tue, 23 Aug 2022 10:31:56 +0200 Subject: [PATCH] boot: simplify bootmeth_vbe_simple_ft_fixup() Don't assign a value to a variable if it is not used afterwards. Move variables to the code fragment where they are used. Addresses-Coverity: CID 356243 ("Code maintainability issues (UNUSED_VALUE)") Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- boot/vbe_simple.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/boot/vbe_simple.c b/boot/vbe_simple.c index a395bc2..0fc5738 100644 --- a/boot/vbe_simple.c +++ b/boot/vbe_simple.c @@ -225,17 +225,16 @@ static int bootmeth_vbe_simple_ft_fixup(void *ctx, struct event *event) { oftree tree = event->data.ft_fixup.tree; struct udevice *dev; - ofnode node; - int ret; /* * Ideally we would have driver model support for fixups, but that does * not exist yet. It is a step too far to try to do this before VBE is * in place. */ - for (ret = vbe_find_first_device(&dev); dev; - ret = vbe_find_next_device(&dev)) { + for (vbe_find_first_device(&dev); dev; vbe_find_next_device(&dev)) { struct simple_state state; + ofnode node; + int ret; if (strcmp("vbe_simple", dev->driver->name)) continue; -- 2.7.4