From 491887c9f25fb710ccbe463aaeeb0f901386861b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jos=C3=A9=20Roberto=20de=20Souza?= Date: Thu, 16 Mar 2023 12:09:56 -0700 Subject: [PATCH] intel: Add TODO about removal of 2Mb alignment in i915 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Xe kmd don't suffer this yet because it still lacks MTL support. Signed-off-by: José Roberto de Souza Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/dev/i915/intel_device_info.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/intel/dev/i915/intel_device_info.c b/src/intel/dev/i915/intel_device_info.c index 982c81e..995cf6f 100644 --- a/src/intel/dev/i915/intel_device_info.c +++ b/src/intel/dev/i915/intel_device_info.c @@ -610,6 +610,10 @@ bool intel_device_info_i915_get_info_from_fd(int fd, struct intel_device_info *d if (getparam(fd, I915_PARAM_HAS_CONTEXT_ISOLATION, &val)) devinfo->has_context_isolation = val; + /* TODO: i915 don't require anymore the 2Mb alignment for gfx 12.5 and + * newer but using 64k brings some issues like unaligned offsets with + * aux map aligned to 1Mb in MTL. + */ if (devinfo->verx10 >= 125) devinfo->mem_alignment = 2 * 1024 * 1024; else if (devinfo->has_local_mem) -- 2.7.4