From 48e7124179192a404121922d2c2f2f355b56ec0e Mon Sep 17 00:00:00 2001 From: Elena Oat Date: Fri, 7 Mar 2014 00:10:34 +0200 Subject: [PATCH] Staging: rtl8188eu: Fix warning of prefer ether_addr_copy(). This patch fixes the warning produced by checkpatch "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)". The address that is copied is a field of nat25_network_db_entry structure. Definition for this struct is found in rtw_br_ext.h file. Pahole shows that the addresses are 2-byte aligned. Signed-off-by: Elena Oat Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8188eu/core/rtw_br_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_br_ext.c b/drivers/staging/rtl8188eu/core/rtw_br_ext.c index 96c8a93..c5a703a 100644 --- a/drivers/staging/rtl8188eu/core/rtw_br_ext.c +++ b/drivers/staging/rtl8188eu/core/rtw_br_ext.c @@ -409,7 +409,7 @@ static void __nat25_db_network_insert(struct adapter *priv, db = priv->nethash[hash]; while (db != NULL) { if (!memcmp(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN)) { - memcpy(db->macAddr, macAddr, ETH_ALEN); + ether_addr_copy(db->macAddr, macAddr); db->ageing_timer = jiffies; spin_unlock_bh(&priv->br_ext_lock); return; @@ -422,7 +422,7 @@ static void __nat25_db_network_insert(struct adapter *priv, return; } memcpy(db->networkAddr, networkAddr, MAX_NETWORK_ADDR_LEN); - memcpy(db->macAddr, macAddr, ETH_ALEN); + ether_addr_copy(db->macAddr, macAddr); atomic_set(&db->use_count, 1); db->ageing_timer = jiffies; -- 2.7.4