From 4899c8ce99cacb940f9442defa69589f95b0e58c Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Tue, 12 Jan 2021 20:26:47 -1000 Subject: [PATCH] target/arm: Introduce PREDDESC field definitions Git-commit: b64ee454a4a086ed459bcda4c0bbb54e197841e4 SVE predicate operations cannot use the "usual" simd_desc encoding, because the lengths are not a multiple of 8. But we were abusing the SIMD_* fields to store values anyway. This abuse broke when SIMD_OPRSZ_BITS was modified in e2e7168a214. Introduce a new set of field definitions for exclusive use of predicates, so that it is obvious what kind of predicate we are manipulating. To be used in future patches. Cc: qemu-stable@nongnu.org Signed-off-by: Richard Henderson Message-id: 20210113062650.593824-2-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell Signed-off-by: Bruce Rogers --- target/arm/internals.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/arm/internals.h b/target/arm/internals.h index 5460678..7369858 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1313,6 +1313,15 @@ void arm_log_exception(int idx); #define TAG_GRANULE (1 << LOG2_TAG_GRANULE) /* + * SVE predicates are 1/8 the size of SVE vectors, and cannot use + * the same simd_desc() encoding due to restrictions on size. + * Use these instead. + */ +FIELD(PREDDESC, OPRSZ, 0, 6) +FIELD(PREDDESC, ESZ, 6, 2) +FIELD(PREDDESC, DATA, 8, 24) + +/* * The SVE simd_data field, for memory ops, contains either * rd (5 bits) or a shift count (2 bits). */ -- 2.7.4