From 47f390e04b82f645446a938f90bae3d7b4e3c9a3 Mon Sep 17 00:00:00 2001 From: Cheoleun Moon Date: Fri, 22 May 2020 10:40:14 +0900 Subject: [PATCH] Coverity issues: Check the return value Change-Id: I007fd637cec56436a2bab4f51253b97a8909ace3 Signed-off-by: Cheoleun Moon --- src/network-state.c | 7 ++++--- src/utils/util.c | 12 ++++++++++-- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/network-state.c b/src/network-state.c index dfdc8c0..c12637d 100755 --- a/src/network-state.c +++ b/src/network-state.c @@ -462,10 +462,11 @@ static void __netconfig_get_default_connection_info(const char *profile) } g_variant_get(variant2, "as", &iter_sub); - g_variant_iter_loop(iter_sub, "s", &value); + if (g_variant_iter_loop(iter_sub, "s", &value)) { + if (value != NULL && (strlen(value) > 0)) + netconfig_default_connection_info.proxy = g_strdup(value); + } g_variant_iter_free(iter_sub); - if (value != NULL && (strlen(value) > 0)) - netconfig_default_connection_info.proxy = g_strdup(value); } else if (g_strcmp0(key2, "Method") == 0) { if (g_variant_is_of_type(variant2, G_VARIANT_TYPE_STRING)) { g_free(key2); diff --git a/src/utils/util.c b/src/utils/util.c index 6bdcf7b..1f631b4 100755 --- a/src/utils/util.c +++ b/src/utils/util.c @@ -825,7 +825,11 @@ int netconfig_add_route_ipv6(gchar *ip_addr, gchar *interface, gchar *gateway, u struct ifreq ifr; memset(&ifr, 0, sizeof(ifr)); strncpy(ifr.ifr_name, interface, sizeof(ifr.ifr_name)-1); - ioctl(fd, SIOCGIFINDEX, &ifr); + if (ioctl(fd, SIOCGIFINDEX, &ifr) < 0) { + ERR("Failed to get ifindex: %d\n", errno); + close(fd); + return -1; + } rt.rtmsg_ifindex = ifr.ifr_ifindex; } @@ -878,7 +882,11 @@ int netconfig_del_route_ipv6(gchar *ip_addr, gchar *interface, gchar *gateway, u struct ifreq ifr; memset(&ifr, 0, sizeof(ifr)); strncpy(ifr.ifr_name, interface, sizeof(ifr.ifr_name)-1); - ioctl(fd, SIOCGIFINDEX, &ifr); + if (ioctl(fd, SIOCGIFINDEX, &ifr) < 0) { + ERR("Failed to get ifindex: %d\n", errno); + close(fd); + return -1; + } rt.rtmsg_ifindex = ifr.ifr_ifindex; } -- 2.34.1