From 47f0384bb96964e1416a52fc03b184a37fe05588 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 24 Jan 2023 15:53:17 -0800 Subject: [PATCH] [lldb][test] Set minimum compiler_versions Set compiler_versions on these tests, as they fail if tested on lower compiler versions versions. Differential Revision: https://reviews.llvm.org/D142513 --- .../deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py | 1 + .../list-dbg-info-content/TestDbgInfoContentListFromStdModule.py | 1 + .../vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py | 1 + .../libcxx/ranges/ref_view/TestDataFormatterLibcxxRangesRefView.py | 3 ++- lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py | 2 +- 5 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py b/lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py index d375e06..cf2f63d 100644 --- a/lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py +++ b/lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py @@ -11,6 +11,7 @@ class TestDbgInfoContentDeque(TestBase): @add_test_categories(["libc++"]) @skipIf(compiler=no_match("clang")) + @skipIf(compiler="clang", compiler_version=['<', '12.0']) def test(self): self.build() diff --git a/lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/TestDbgInfoContentListFromStdModule.py b/lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/TestDbgInfoContentListFromStdModule.py index 32b838c..0c6d62a 100644 --- a/lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/TestDbgInfoContentListFromStdModule.py +++ b/lldb/test/API/commands/expression/import-std-module/list-dbg-info-content/TestDbgInfoContentListFromStdModule.py @@ -12,6 +12,7 @@ class TestDbgInfoContentList(TestBase): @add_test_categories(["libc++"]) @skipIf(compiler=no_match("clang")) + @skipIf(compiler="clang", compiler_version=['<', '12.0']) def test(self): self.build() diff --git a/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py b/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py index 7da615c..c4cfedb 100644 --- a/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py +++ b/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py @@ -12,6 +12,7 @@ class TestDbgInfoContentVector(TestBase): @add_test_categories(["libc++"]) @skipIf(compiler=no_match("clang")) + @skipIf(compiler="clang", compiler_version=['<', '12.0']) def test(self): self.build() diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/ranges/ref_view/TestDataFormatterLibcxxRangesRefView.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/ranges/ref_view/TestDataFormatterLibcxxRangesRefView.py index 1fc8026..ff897b2 100644 --- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/ranges/ref_view/TestDataFormatterLibcxxRangesRefView.py +++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/ranges/ref_view/TestDataFormatterLibcxxRangesRefView.py @@ -28,7 +28,8 @@ class LibcxxRangesRefViewDataFormatterTestCase(TestBase): children=self.check_string_vec_children()) @add_test_categories(["libc++"]) - @skipIf(compiler=no_match("clang"), compiler_version=['<', '16.0']) + @skipIf(compiler=no_match("clang")) + @skipIf(compiler="clang", compiler_version=['<', '16.0']) def test_with_run_command(self): """Test that std::ranges::ref_view is formatted correctly when printed. """ diff --git a/lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py b/lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py index ed89377..c7e83be 100644 --- a/lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py +++ b/lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py @@ -1,6 +1,6 @@ from lldbsuite.test import lldbinline from lldbsuite.test import decorators -decor = [decorators.skipIf(compiler="clang", compiler_version=['<', '13.0'])] +decor = [decorators.skipIf(compiler="clang", compiler_version=['<', '16.0'])] lldbinline.MakeInlineTest( __file__, globals(), decor) -- 2.7.4