From 47e7cef66acaf0cfbf586d1a566e7472592e5f8f Mon Sep 17 00:00:00 2001 From: David Wrighton Date: Wed, 16 Sep 2020 11:20:40 -0700 Subject: [PATCH] Adjust console error logging for msbuild (#42285) - Show a summary of error on completion - And don't attempt to force alignment to screen width (which will allow for better copy/paste from the console) --- src/coreclr/build-runtime.cmd | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/coreclr/build-runtime.cmd b/src/coreclr/build-runtime.cmd index e6acb89..c152d94 100644 --- a/src/coreclr/build-runtime.cmd +++ b/src/coreclr/build-runtime.cmd @@ -67,6 +67,7 @@ set __PgoInstrument=0 set __PgoOptimize=1 set __EnforcePgo=0 set __IbcTuning= +set __ConsoleLoggingParameters=/clp:ForceNoAlign;Summary REM __PassThroughArgs is a set of things that will be passed through to nested calls to build.cmd REM when using "all". @@ -497,7 +498,7 @@ if %__BuildCrossArchNative% EQU 1 ( set "__MsbuildWrn=/flp1:WarningsOnly;LogFile=!__BuildWrn!" set "__MsbuildErr=/flp2:ErrorsOnly;LogFile=!__BuildErr!" set "__MsbuildBinLog=/bl:!__BinLog!" - set "__Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! !__MsbuildBinLog!" + set "__Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! !__MsbuildBinLog! !__ConsoleLoggingParameters!" REM We pass the /m flag directly to MSBuild so that we can get both MSBuild and CL parallelism, which is fastest for our builds. "%CMakePath%" --build %__CrossCompIntermediatesDir% --target install --config %__BuildType% -- /nologo /m !__Logging! @@ -521,7 +522,7 @@ if %__BuildCrossArchNative% EQU 1 ( set "__MsbuildWrn=/flp1:WarningsOnly;LogFile=!__BuildWrn!" set "__MsbuildErr=/flp2:ErrorsOnly;LogFile=!__BuildErr!" set "__MsbuildBinLog=/bl:!__BinLog!" - set "__Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! !__MsbuildBinLog!" + set "__Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! !__MsbuildBinLog! !__ConsoleLoggingParameters!" REM We pass the /m flag directly to MSBuild so that we can get both MSBuild and CL parallelism, which is fastest for our builds. "%CMakePath%" --build %__CrossComp2IntermediatesDir% --target install --config %__BuildType% -- /nologo /m !__Logging! @@ -605,7 +606,7 @@ if %__BuildNative% EQU 1 ( set "__MsbuildWrn=/flp1:WarningsOnly;LogFile=!__BuildWrn!" set "__MsbuildErr=/flp2:ErrorsOnly;LogFile=!__BuildErr!" set "__MsbuildBinLog=/bl:!__BinLog!" - set "__Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! !__MsbuildBinLog!" + set "__Logging=!__MsbuildLog! !__MsbuildWrn! !__MsbuildErr! !__MsbuildBinLog! !__ConsoleLoggingParameters!" REM We pass the /m flag directly to MSBuild so that we can get both MSBuild and CL parallelism, which is fastest for our builds. "%CMakePath%" --build %__IntermediatesDir% --target install --config %__BuildType% -- /nologo /m !__Logging! -- 2.7.4