From 47b354129a2bb4d9a882914e228aa25f33a1d0e1 Mon Sep 17 00:00:00 2001 From: Luis Lavena Date: Mon, 5 Dec 2011 12:08:47 -0300 Subject: [PATCH] visibility=hidden should not be used for Windows While GCC 4.x supports the usage of -fvisibility=hidden and the related pragmas, usage of it under MinGW is a noop and should not be used. Instead, __declspec(dllexport/dllimport) should be used instead to indicate exportable functions. Since Ninja builds a static library, no functions are exported and visibility, at least under MinGW, is not an issue. --- configure.py | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.py b/configure.py index 97caec0..e9b37b2 100755 --- a/configure.py +++ b/configure.py @@ -82,6 +82,7 @@ ldflags = ['-L$builddir'] libs = [] if platform == 'mingw': + cflags.remove('-fvisibility=hidden'); cflags.append('-Igtest-1.6.0/include') ldflags.append('-Lgtest-1.6.0/lib/.libs') ldflags.extend(['-static-libgcc', '-static-libstdc++']) -- 2.7.4