From 47adfd01c9b41b90c609211368e9a87c24932c4c Mon Sep 17 00:00:00 2001 From: Carol Eidt Date: Fri, 10 Feb 2017 19:28:22 -0800 Subject: [PATCH] Update lsra-throughput.md Commit migrated from https://github.com/dotnet/coreclr/commit/6f33e3be7d2c0f508bcdb0bd5f00367ec7a4c5be --- docs/coreclr/design-docs/lsra-throughput.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/coreclr/design-docs/lsra-throughput.md b/docs/coreclr/design-docs/lsra-throughput.md index 9eee5da..4fd704c 100644 --- a/docs/coreclr/design-docs/lsra-throughput.md +++ b/docs/coreclr/design-docs/lsra-throughput.md @@ -53,6 +53,10 @@ I propose instead to do the following: * I don't know if we need `REG_OPT_DEF`, but that could be added as well. * Having done this, we can greatly simplify `IsContained()`. +It may be more effective to use the extra bit for an actual `GTF_CONTAINED` flag, and that is something we might want to consider +eventually, but initially it is easier to simplify the containedness check using `GTF_TREE_ROOT` without having to change all the +places that currently mark nodes as contained. + Combining Containedness Analysis with Lowering ============================================== Once we've changed containedness to use the above representation, we can move the code to set it into the first pass of `Lowering`. -- 2.7.4