From 47807c4cfa5ffe1e5da27e3d3056d9b47ba998c5 Mon Sep 17 00:00:00 2001 From: Yauheni Kaliuta Date: Sun, 29 Nov 2020 18:47:35 +0200 Subject: [PATCH] libkmod: kmod_builtin_get_modinfo: free modinfo on error The function allocates array but on building it if get_string() fails it returns the error leaving the array allocated. The caller does not care about it in error case either. Free it to fix memory leak. Signed-off-by: Yauheni Kaliuta --- libkmod/libkmod-builtin.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libkmod/libkmod-builtin.c b/libkmod/libkmod-builtin.c index aaec5dd..fc9a376 100644 --- a/libkmod/libkmod-builtin.c +++ b/libkmod/libkmod-builtin.c @@ -314,6 +314,7 @@ ssize_t kmod_builtin_get_modinfo(struct kmod_ctx *ctx, const char *modname, offset = get_string(iter, pos, &line, &linesz); if (offset <= 0) { count = (offset) ? -errno : -EOF; + free(*modinfo); goto fail; } -- 2.7.4