From 47595a857f093ee6e41758efe8175e425e4d1b63 Mon Sep 17 00:00:00 2001 From: Ondrej Holy Date: Mon, 20 Aug 2018 11:26:35 +0200 Subject: [PATCH] core/transport: Fix leak found by covscan 0 is valid return value from socket(). leaked_handle: Handle variable "sockfd" going out of scope leaks the handle. --- libfreerdp/core/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libfreerdp/core/transport.c b/libfreerdp/core/transport.c index 8c1ef1f..01e8682 100644 --- a/libfreerdp/core/transport.c +++ b/libfreerdp/core/transport.c @@ -419,7 +419,7 @@ BOOL transport_connect(rdpTransport* transport, const char* hostname, else sockfd = freerdp_tcp_connect(context, settings, hostname, port, timeout); - if (sockfd < 1) + if (sockfd < 0) return FALSE; if (!transport_attach(transport, sockfd)) -- 2.7.4