From 4735f0edf4265e3e260e10a12921baf17987a020 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 29 Jun 2018 15:10:04 -0600 Subject: [PATCH] Use scoped_free_pendings in coff_symtab_read PR gdb/18624 concerns an assertion failure that occurs when setting a breakpoint in a Go program on Windows. What happens here is that coff_symtab_read uses buildsym but does not instantiate scoped_free_pendings. So, the struct pending objects are never released. Later, dwarf2read.c calls buildsym_init, which asserts. This patch fixes the problem by instantiating scoped_free_pendings in coff_symtab_read. Tested using the test executable from the PR. I don't know how to test this more fully. gdb/ChangeLog 2018-07-17 Tom Tromey PR gdb/18624: * coffread.c (coff_symtab_read): Use scoped_free_pendings. --- gdb/ChangeLog | 5 +++++ gdb/coffread.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 635f592..01c1a25 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-07-17 Tom Tromey + + PR gdb/18624: + * coffread.c (coff_symtab_read): Use scoped_free_pendings. + 2018-07-16 Jim Wilson * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi. diff --git a/gdb/coffread.c b/gdb/coffread.c index b13d901..ff55542 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -804,6 +804,9 @@ coff_symtab_read (minimal_symbol_reader &reader, CORE_ADDR tmpaddr; struct minimal_symbol *msym; + buildsym_init (); + scoped_free_pendings free_pending; + /* Work around a stdio bug in SunOS4.1.1 (this makes me nervous.... it's hard to know I've really worked around it. The fix should be harmless, anyway). The symptom of the bug is that the first -- 2.7.4