From 46a3c9ac8b2f8182ef8f211f4be09a67e4d42a61 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Sat, 16 Apr 2016 02:17:26 +1000 Subject: [PATCH] Revert "pulsesink: uncork if needed upon commit" This reverts commit 0dd46accf6d282ff07065852bd91c85c78af3394. With some audiosinks, starting the ringbuffer on the first commit causes audio glitches at startup by starting to output segments from the ringbuffer before it has been filled / fully prerolled. This doesn't usually happen with pulsesink because we map the pulseaudio ringbuffer directly, but we should keep things consistent with other sinks with regards to startup latency, plus it gives more headway to avoid glitching, should the initial 2nd segment take more than 10ms to generate. https://bugzilla.gnome.org/show_bug.cgi?id=657076 --- ext/pulse/pulsesink.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c index 76cfc54f9a..521c4a6024 100644 --- a/ext/pulse/pulsesink.c +++ b/ext/pulse/pulsesink.c @@ -1516,12 +1516,6 @@ gst_pulseringbuffer_commit (GstAudioRingBuffer * buf, guint64 * sample, if (pbuf->paused) goto was_paused; - /* ensure running clock for whatever out there */ - if (pbuf->corked) { - if (!gst_pulsering_set_corked (pbuf, FALSE, FALSE)) - goto uncork_failed; - } - /* offset is in bytes */ offset = *sample * bpf; -- 2.34.1