From 468a3dbb56580121971613e1f6a8736b6e648eb9 Mon Sep 17 00:00:00 2001 From: Dongju Chae Date: Fri, 22 May 2020 17:12:15 +0900 Subject: [PATCH] [Fix/Svace] Resolve a few svace issues This patch resolves a few svace issues, which includes - UNINIT.CTOR - UNREACHABLE_CODE Signed-off-by: Dongju Chae --- src/core/ne-scheduler.cc | 4 ++-- src/core/ne-segment-table.cc | 2 ++ src/core/npu/NPUdrvAPI_emul.cc | 2 ++ tests/utils/ne_test_utils.c | 2 ++ 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/core/ne-scheduler.cc b/src/core/ne-scheduler.cc index 78590ee..fb7454c 100644 --- a/src/core/ne-scheduler.cc +++ b/src/core/ne-scheduler.cc @@ -21,8 +21,8 @@ std::atomic Request::global_request_id_ (1); /** @brief constructor of request class */ Request::Request (npu_input_opmode opmode) - : opmode_ (opmode), force_stop_ (false), model_ (NULL), - buffer_ (NULL), cb_ (NULL) + : opmode_ (opmode), force_stop_ (false), model_ (nullptr), + buffer_ (nullptr), segt_ (nullptr), cb_ (nullptr) { request_id_ = Request::global_request_id_.fetch_add(1); } diff --git a/src/core/ne-segment-table.cc b/src/core/ne-segment-table.cc index e57108c..1d4ee20 100644 --- a/src/core/ne-segment-table.cc +++ b/src/core/ne-segment-table.cc @@ -24,6 +24,8 @@ SegmentTable::SegmentTable (const HWmemImpl* impl) weight_seg_idx_ (nullptr), input_seg_idx_ (nullptr), output_seg_idx_ (nullptr), + input_seg_off_ (0), + output_seg_off_ (0), num_total_segments_ (0), num_weight_segments_ (0), num_input_segments_ (0), diff --git a/src/core/npu/NPUdrvAPI_emul.cc b/src/core/npu/NPUdrvAPI_emul.cc index d9b62dc..975c40c 100644 --- a/src/core/npu/NPUdrvAPI_emul.cc +++ b/src/core/npu/NPUdrvAPI_emul.cc @@ -96,6 +96,8 @@ EmulElement::EmulElement (size_t size) assert (addr_); memset (addr_, '\x00', size); + memset (&model_, '\x00', sizeof (model_config_t)); + size_ = size; dmabuf_ = global_id_.fetch_add (1); diff --git a/tests/utils/ne_test_utils.c b/tests/utils/ne_test_utils.c index 408b340..783b5c4 100644 --- a/tests/utils/ne_test_utils.c +++ b/tests/utils/ne_test_utils.c @@ -223,7 +223,9 @@ recheck: if (alloc_total != free_total) { if (!rechecked) { + rechecked = true; sleep (1); /* there may be a timing issue until all resources are freed */ + goto recheck; } -- 2.7.4