From 468494c28849c0ee40f4f7046892a12e5ed4ab82 Mon Sep 17 00:00:00 2001 From: Sangyoon Jang Date: Mon, 30 May 2022 17:33:17 +0900 Subject: [PATCH] Fix signal agent Add null-checking before releasing objects. Change-Id: I6a28bcbd6574a266e75428517e441bf71817407e Signed-off-by: Sangyoon Jang --- installer/pkgmgr_installer_signal_agent.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/installer/pkgmgr_installer_signal_agent.c b/installer/pkgmgr_installer_signal_agent.c index 3adcc75..19c5b44 100644 --- a/installer/pkgmgr_installer_signal_agent.c +++ b/installer/pkgmgr_installer_signal_agent.c @@ -47,7 +47,7 @@ #define PWBUFSIZE sysconf(_SC_GETPW_R_SIZE_MAX) #define APPFW_USERNAME "app_fw" -static int server_fd; +static int server_fd = -1; static GMainLoop *loop; static guint sid; static guint tid; @@ -311,10 +311,14 @@ static int __init(void) static void __fini(void) { - g_source_remove(sid); - g_main_loop_unref(loop); - g_object_unref(conn); - close(server_fd); + if (sid > 0) + g_source_remove(sid); + if (loop) + g_main_loop_unref(loop); + if (conn) + g_object_unref(conn); + if (server_fd > 0) + close(server_fd); } int main(int argc, char *argv[]) -- 2.34.1