From 465fc808415b6870f9c2a3fb051eb94dccbcb92c Mon Sep 17 00:00:00 2001 From: Radoslaw Cybulski Date: Tue, 30 Apr 2019 11:59:53 +0000 Subject: [PATCH] Fix for invalid ATSPI role on naviframe page element ATSPI role page_tab was set on invalid object and thus ignored. Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D8789 --- src/lib/elementary/elc_naviframe.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/lib/elementary/elc_naviframe.c b/src/lib/elementary/elc_naviframe.c index 9cb147c..ec00f1c 100644 --- a/src/lib/elementary/elc_naviframe.c +++ b/src/lib/elementary/elc_naviframe.c @@ -1439,8 +1439,6 @@ _item_new(Evas_Object *obj, ELM_NAVIFRAME_DATA_GET(obj, sd); eo_item = efl_add(ELM_NAVIFRAME_ITEM_CLASS, obj); - efl_access_object_role_set(eo_item, EFL_ACCESS_ROLE_PAGE_TAB); - efl_access_object_i18n_name_set(eo_item, (char*)title_label); if (!eo_item) { @@ -1451,9 +1449,13 @@ _item_new(Evas_Object *obj, ELM_NAVIFRAME_ITEM_DATA_GET(eo_item, it); //item base layout - VIEW_SET(it, elm_layout_add(obj)); + Eo *elem = elm_layout_add(obj); + VIEW_SET(it, elem); evas_object_smart_member_add(VIEW(it), obj); + efl_access_object_role_set(elem, EFL_ACCESS_ROLE_PAGE_TAB); + efl_access_object_i18n_name_set(elem, (char*)title_label); + if (!elm_widget_sub_object_add(obj, VIEW(it))) ERR("could not add %p as sub object of %p", VIEW(it), obj); -- 2.7.4