From 465cfcb2663fa732041627e5a35c6cadb7851e75 Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Wed, 24 Oct 2018 12:30:03 -0700 Subject: [PATCH] util/gen_xmlpool: Don't use len to test for container emptiness This is a very common python anti-pattern. Not using length allows us to go through faster C paths, but has the same meaning. Reviewed-by: Emil Velikov --- src/util/xmlpool/gen_xmlpool.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpool.py index 078bced..f1983c7 100644 --- a/src/util/xmlpool/gen_xmlpool.py +++ b/src/util/xmlpool/gen_xmlpool.py @@ -182,7 +182,7 @@ def main(): with io.open(args.template, mode="rt", encoding='utf-8') as template: descMatches = [] for line in template: - if len(descMatches) > 0: + if descMatches: matchENUM = reENUM.match(line) matchDESC_END = reDESC_END.match(line) if matchENUM: @@ -201,16 +201,16 @@ def main(): matchDESC = reDESC.match(line) matchDESC_BEGIN = reDESC_BEGIN.match(line) if matchDESC: - assert len(descMatches) == 0 + assert not descMatches expandMatches([matchDESC], translations, output) elif matchDESC_BEGIN: - assert len(descMatches) == 0 + assert not descMatches descMatches = [matchDESC_BEGIN] else: output.write(line) - if len(descMatches) > 0: + if descMatches: print("Warning: unterminated description at end of file.", file=sys.stderr) expandMatches(descMatches, translations, output) -- 2.7.4