From 460c0abfbb6390533a8a04e661971ff0ad4c6cbd Mon Sep 17 00:00:00 2001 From: Siarhei Siamashka Date: Thu, 14 May 2009 06:38:49 +0000 Subject: [PATCH] Fix for issue #829 ("ffvorbis outputs crackling sound, libvorbis plays fine") This was off-by-one bug which affects floor0 encoded files. Tracked down by valgrind (was reported as the use of uninitialized memory). With this patch applied, tiny_psnr now reports the following when ffvorbis is compared to libvorbis-1.0beta4 output for 'lsp-test.ogg' sample: stddev: 0.76 PSNR: 98.69 bytes: 3498380/ 3498452 Output from libvorbis-1.2 is substantially different: stddev: 132.57 PSNR: 53.87 bytes: 3498424/ 3498496 Originally committed as revision 18821 to svn://svn.ffmpeg.org/ffmpeg/trunk --- libavcodec/vorbis_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vorbis_dec.c b/libavcodec/vorbis_dec.c index 12a9fed..b304e7b 100644 --- a/libavcodec/vorbis_dec.c +++ b/libavcodec/vorbis_dec.c @@ -1054,7 +1054,7 @@ static uint_fast8_t vorbis_floor0_decode(vorbis_context *vc, float two_cos_w=2.0f*cos(wstep*iter_cond); // needed all times /* similar part for the q and p products */ - for(j=0;j