From 45e5041e54d698d2e6eac927860d2714200ccbc9 Mon Sep 17 00:00:00 2001 From: Robert Yang Date: Tue, 17 Jul 2012 12:38:00 +0000 Subject: [PATCH] kernel.bbclass: replace os.system with subprocess.call Replace os.system with subprocess.call since the older function would fail (more or less) silently if the executed program cannot be found More info: http://docs.python.org/library/subprocess.html#subprocess-replacements [YOCTO #2454] (From meta-openembedded rev: 778f8b62c597f0550c33db4ab00f44979e02daa1) Signed-off-by: Robert Yang Signed-off-by: Richard Purdie Signed-off-by: Martin Jansa Signed-off-by: Koen Kooi Signed-off-by: Patrick Ohly --- meta-openembedded/meta-oe/classes/kernel.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta-openembedded/meta-oe/classes/kernel.bbclass b/meta-openembedded/meta-oe/classes/kernel.bbclass index 248cd28..810d6de 100644 --- a/meta-openembedded/meta-oe/classes/kernel.bbclass +++ b/meta-openembedded/meta-oe/classes/kernel.bbclass @@ -316,12 +316,12 @@ module_conf_rfcomm = "alias bt-proto-3 rfcomm" python populate_packages_prepend () { def extract_modinfo(file): - import tempfile, re + import tempfile, re, subprocess tempfile.tempdir = d.getVar("WORKDIR", True) tf = tempfile.mkstemp() tmpfile = tf[1] cmd = "PATH=\"%s\" %sobjcopy -j .modinfo -O binary %s %s" % (d.getVar("PATH", True), d.getVar("HOST_PREFIX", True) or "", file, tmpfile) - os.system(cmd) + subprocess.call(cmd, shell=True) f = open(tmpfile) l = f.read().split("\000") f.close() -- 2.7.4