From 457063f22021ac0a22d8c5d0041017e6ded89fc6 Mon Sep 17 00:00:00 2001 From: Tomas Mlcoch Date: Mon, 25 Feb 2013 12:08:17 +0100 Subject: [PATCH] Remove redundant MODULE constant. --- src/compression_wrapper.c | 37 +++++++------- src/load_metadata.c | 123 ++++++++++++++++++++++------------------------ src/locate_metadata.c | 63 +++++++++++------------- src/misc.c | 58 ++++++++++------------ src/parsehdr.c | 3 -- src/parsepkg.c | 32 ++++++------ src/repomd.c | 29 +++++------ src/sqlite.c | 10 ---- 8 files changed, 161 insertions(+), 194 deletions(-) diff --git a/src/compression_wrapper.c b/src/compression_wrapper.c index 7bc0fe1..a436bd8 100644 --- a/src/compression_wrapper.c +++ b/src/compression_wrapper.c @@ -30,9 +30,6 @@ #include "logging.h" #include "compression_wrapper.h" -#undef MODULE -#define MODULE "compression_wrapper: " - /* #define Z_CR_CW_NO_COMPRESSION 0 #define Z_BEST_SPEED 1 @@ -100,7 +97,7 @@ cr_detect_compression(const char *filename) cr_CompressionType type = CR_CW_UNKNOWN_COMPRESSION; if (!g_file_test(filename, G_FILE_TEST_EXISTS | G_FILE_TEST_IS_REGULAR)) { - g_debug(MODULE"%s: File %s doesn't exists or it's not a regular file", + g_debug("%s: File %s doesn't exists or it's not a regular file", __func__, filename); return type; } @@ -131,14 +128,14 @@ cr_detect_compression(const char *filename) magic_t myt = magic_open(MAGIC_MIME); magic_load(myt, NULL); if (magic_check(myt, NULL) == -1) { - g_critical(MODULE"%s: magic_check() failed", __func__); + g_critical("%s: magic_check() failed", __func__); return type; } const char *mime_type = magic_file(myt, filename); if (mime_type) { - g_debug(MODULE"%s: Detected mime type: %s (%s)", __func__, mime_type, + g_debug("%s: Detected mime type: %s (%s)", __func__, mime_type, filename); if (g_str_has_prefix(mime_type, "application/x-gzip") || @@ -177,7 +174,7 @@ cr_detect_compression(const char *filename) type = CR_CW_NO_COMPRESSION; } } else { - g_debug(MODULE"%s: Mime type not detected! (%s)", __func__, filename); + g_debug("%s: Mime type not detected! (%s)", __func__, filename); } @@ -220,7 +217,7 @@ cr_open(const char *filename, cr_OpenMode mode, cr_CompressionType comtype) cr_CompressionType type; if (!filename || (mode != CR_CW_MODE_READ && mode != CR_CW_MODE_WRITE)) { - g_debug(MODULE"%s: Filename is NULL or bad mode value", __func__); + g_debug("%s: Filename is NULL or bad mode value", __func__); return NULL; } @@ -229,13 +226,13 @@ cr_open(const char *filename, cr_OpenMode mode, cr_CompressionType comtype) if (mode == CR_CW_MODE_WRITE) { if (comtype == CR_CW_AUTO_DETECT_COMPRESSION) { - g_debug(MODULE"%s: CR_CW_AUTO_DETECT_COMPRESSION cannot be used if " + g_debug("%s: CR_CW_AUTO_DETECT_COMPRESSION cannot be used if " "mode is CR_CW_MODE_WRITE", __func__); return NULL; } if (comtype == CR_CW_UNKNOWN_COMPRESSION) { - g_debug(MODULE"%s: CR_CW_UNKNOWN_COMPRESSION cannot be used if mode" + g_debug("%s: CR_CW_UNKNOWN_COMPRESSION cannot be used if mode" " is CR_CW_MODE_WRITE", __func__); return NULL; } @@ -249,7 +246,7 @@ cr_open(const char *filename, cr_OpenMode mode, cr_CompressionType comtype) } if (type == CR_CW_UNKNOWN_COMPRESSION) { - g_debug(MODULE"%s: Cannot detect compression type", __func__); + g_debug("%s: Cannot detect compression type", __func__); return NULL; } @@ -282,7 +279,7 @@ cr_open(const char *filename, cr_OpenMode mode, cr_CompressionType comtype) } if (gzbuffer((gzFile) file->FILE, GZ_BUFFER_SIZE) == -1) { - g_debug(MODULE"%s: gzbuffer() call failed", __func__); + g_debug("%s: gzbuffer() call failed", __func__); } break; @@ -335,20 +332,20 @@ cr_open(const char *filename, cr_OpenMode mode, cr_CompressionType comtype) if (ret != LZMA_OK) { switch (ret) { case LZMA_MEM_ERROR: - g_debug(MODULE"%s: XZ: Cannot allocate memory", + g_debug("%s: XZ: Cannot allocate memory", __func__); break; case LZMA_OPTIONS_ERROR: - g_debug(MODULE"%s: XZ: Unsupported flags (options)", + g_debug("%s: XZ: Unsupported flags (options)", __func__); break; case LZMA_PROG_ERROR: - g_debug(MODULE"%s: XZ: One or more of the parameters " + g_debug("%s: XZ: One or more of the parameters " "have values that will never be valid.", __func__); break; default: - g_debug(MODULE"%s: XZ: Unknown error", __func__); + g_debug("%s: XZ: Unknown error", __func__); } g_free((void *) xz_file); break; @@ -522,10 +519,10 @@ cr_read(CR_FILE *cr_file, void *buffer, unsigned int len) // Fill input buffer if (stream->avail_in == 0) { if ((lret = fread(xz_file->buffer, 1, XZ_BUFFER_SIZE, xz_file->file)) < 0) { - g_debug(MODULE"%s: XZ: Error while fread", __func__); + g_debug("%s: XZ: Error while fread", __func__); return CR_CW_ERR; // Error while reading input file } else if (lret == 0) { - g_debug(MODULE"%s: EOF", __func__); + g_debug("%s: EOF", __func__); break; // EOF } stream->next_in = xz_file->buffer; @@ -535,7 +532,7 @@ cr_read(CR_FILE *cr_file, void *buffer, unsigned int len) // Decode lret = lzma_code(stream, LZMA_RUN); if (lret != LZMA_OK && lret != LZMA_STREAM_END) { - g_debug(MODULE"%s: XZ: Error while decoding (%d)", __func__, lret); + g_debug("%s: XZ: Error while decoding (%d)", __func__, lret); return CR_CW_ERR; // Error while decoding } if (lret == LZMA_STREAM_END) { @@ -705,7 +702,7 @@ cr_printf(CR_FILE *cr_file, const char *format, ...) va_end(vl); if (ret < 0) { - g_debug(MODULE"%s: vasprintf() call failed", __func__); + g_debug("%s: vasprintf() call failed", __func__); return CR_CW_ERR; } diff --git a/src/load_metadata.c b/src/load_metadata.c index bec7c36..4742479 100644 --- a/src/load_metadata.c +++ b/src/load_metadata.c @@ -31,9 +31,6 @@ #include "compression_wrapper.h" #include "locate_metadata.h" -#undef MODULE -#define MODULE "load_metadata: " - #define STRINGCHUNK_SIZE 16384 #define CHUNK_SIZE 8192 #define PKGS_REALLOC_STEP 2000 @@ -219,7 +216,7 @@ pri_start_handler(void *data, const char *el, const char **attr) } else if (!strcmp(el, "rpm:entry")) { if (!pkg) { ppd->error = TRUE; - g_critical(MODULE"%s: Have but pkg object doesn't exist!", + g_critical("%s: Have but pkg object doesn't exist!", __func__); return; } @@ -245,7 +242,7 @@ pri_start_handler(void *data, const char *el, const char **attr) dependency->pre = TRUE; } } else { - g_warning(MODULE"%s: Unknown attribute \"%s\"", __func__, attr[i]); + g_warning("%s: Unknown attribute \"%s\"", __func__, attr[i]); } } @@ -264,7 +261,7 @@ pri_start_handler(void *data, const char *el, const char **attr) break; default: g_free(dependency); - g_warning(MODULE"%s: Bad context (%d) for rpm:entry", __func__, + g_warning("%s: Bad context (%d) for rpm:entry", __func__, ppd->context); break; } @@ -274,12 +271,12 @@ pri_start_handler(void *data, const char *el, const char **attr) // Check sanity if (ppd->context != METADATA) { ppd->error = TRUE; - g_critical(MODULE"%s: Package element: Bad XML context!", __func__); + g_critical("%s: Package element: Bad XML context!", __func__); return; } if (ppd->pkg) { ppd->error = TRUE; - g_critical(MODULE"%s: Package element: Pkg pointer is not NULL", + g_critical("%s: Package element: Pkg pointer is not NULL", __func__); return; } @@ -303,7 +300,7 @@ pri_start_handler(void *data, const char *el, const char **attr) } else if (!strcmp(el, "version")) { if (!pkg) { ppd->error = TRUE; - g_critical(MODULE"%s: Have but pkg object doesn't exist!", + g_critical("%s: Have but pkg object doesn't exist!", __func__); return; } @@ -316,7 +313,7 @@ pri_start_handler(void *data, const char *el, const char **attr) } else if (!strcmp(attr[i], "rel")) { pkg->release = g_string_chunk_insert(pkg->chunk, attr[i+1]); } else { - g_warning(MODULE"%s: Unknown attribute \"%s\"", __func__, attr[i]); + g_warning("%s: Unknown attribute \"%s\"", __func__, attr[i]); } } @@ -326,7 +323,7 @@ pri_start_handler(void *data, const char *el, const char **attr) if (!pkg) { ppd->error = TRUE; - g_critical(MODULE"%s: Have but pkg object doesn't exist!", + g_critical("%s: Have but pkg object doesn't exist!", __func__); return; } @@ -357,7 +354,7 @@ pri_start_handler(void *data, const char *el, const char **attr) } else if (!strcmp(el, "time")) { if (!pkg) { ppd->error = TRUE; - g_critical(MODULE"%s: Have