From 4533294e986f198f99b99e257a0cdb60a928ed8e Mon Sep 17 00:00:00 2001 From: "svenpanne@chromium.org" Date: Wed, 9 Jul 2014 12:12:21 +0000 Subject: [PATCH] Fixed printing of external references. Previously we relied on undefined behavior (printf("%s", NULL)), now we explicitly emit "" when we hit an external reference with an unknown name. BUG=392068 LOG=y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/379843002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22302 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/serialize.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/serialize.cc b/src/serialize.cc index 7d6a482..9e203b5 100644 --- a/src/serialize.cc +++ b/src/serialize.cc @@ -561,8 +561,8 @@ uint32_t ExternalReferenceEncoder::Encode(Address key) const { const char* ExternalReferenceEncoder::NameOfAddress(Address key) const { int index = IndexOf(key); - return index >= 0 ? - ExternalReferenceTable::instance(isolate_)->name(index) : NULL; + return index >= 0 ? ExternalReferenceTable::instance(isolate_)->name(index) + : ""; } -- 2.7.4