From 451a5694e245d1c5f58504b85f0d6c685e9856b9 Mon Sep 17 00:00:00 2001 From: Seungbae Shin Date: Wed, 17 Mar 2021 14:00:43 +0900 Subject: [PATCH] Use static for global variables [Version] 0.10.229 [Issue Type] SAM Improvement Change-Id: I59fa8d5c794d6c57938accd90b43a8231897b842 --- packaging/libmm-camcorder.spec | 2 +- src/mm_camcorder_exifinfo.c | 2 +- src/mm_camcorder_gstcommon.c | 4 ++-- src/mm_camcorder_platform.c | 32 ++++++++++++++++---------------- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/packaging/libmm-camcorder.spec b/packaging/libmm-camcorder.spec index cf80bc8..2e82404 100755 --- a/packaging/libmm-camcorder.spec +++ b/packaging/libmm-camcorder.spec @@ -1,6 +1,6 @@ Name: libmm-camcorder Summary: Camera and recorder library -Version: 0.10.228 +Version: 0.10.229 Release: 0 Group: Multimedia/Libraries License: Apache-2.0 diff --git a/src/mm_camcorder_exifinfo.c b/src/mm_camcorder_exifinfo.c index c907b5d..a594460 100644 --- a/src/mm_camcorder_exifinfo.c +++ b/src/mm_camcorder_exifinfo.c @@ -48,7 +48,7 @@ */ #include #define _EXIF_BIN_SIZE_ ((unsigned int)174) -unsigned char g_exif_bin[_EXIF_BIN_SIZE_] = { +static unsigned char g_exif_bin[_EXIF_BIN_SIZE_] = { 0x45 , 0x78 , 0x69 , 0x66 , 0x00 , 0x00 , 0x49 , 0x49 , 0x2a , 0x00 , 0x08 , 0x00 , 0x00 , 0x00 , 0x05 , 0x00 , 0x1a , 0x01 , 0x05 , 0x00 , 0x01 , 0x00 , 0x00 , 0x00 , 0x4a , 0x00 , 0x00 , 0x00 , 0x1b , 0x01 , 0x05 , 0x00 , 0x01 , 0x00 , 0x00 , 0x00 , 0x52 , 0x00 , 0x00 , 0x00 , 0x28 , 0x01 , 0x03 , 0x00 , 0x01 , 0x00 , 0x00 , 0x00 , diff --git a/src/mm_camcorder_gstcommon.c b/src/mm_camcorder_gstcommon.c index 7a65272..47243a3 100755 --- a/src/mm_camcorder_gstcommon.c +++ b/src/mm_camcorder_gstcommon.c @@ -40,7 +40,7 @@ | GLOBAL VARIABLE DEFINITIONS for internal | -----------------------------------------------------------------------*/ /* Table for compatibility between audio codec and file format */ -gboolean audiocodec_fileformat_compatibility_table[MM_AUDIO_CODEC_NUM][MM_FILE_FORMAT_NUM] = { +static gboolean audiocodec_fileformat_compatibility_table[MM_AUDIO_CODEC_NUM][MM_FILE_FORMAT_NUM] = { /* 3GP ASF AVI MATROSKA MP4 OGG NUT QT REAL AMR AAC MP3 AIFF AU WAV MID MMF DIVX FLV VOB IMELODY WMA WMV JPG FLAC M2TS*/ /*AMR*/ { 1, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, /*G723.1*/ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, @@ -89,7 +89,7 @@ gboolean audiocodec_fileformat_compatibility_table[MM_AUDIO_CODEC_NUM][MM_FILE_F }; /* Table for compatibility between video codec and file format */ -gboolean videocodec_fileformat_compatibility_table[MM_VIDEO_CODEC_NUM][MM_FILE_FORMAT_NUM] = { +static gboolean videocodec_fileformat_compatibility_table[MM_VIDEO_CODEC_NUM][MM_FILE_FORMAT_NUM] = { /* 3GP ASF AVI MATROSKA MP4 OGG NUT QT REAL AMR AAC MP3 AIFF AU WAV MID MMF DIVX FLV VOB IMELODY WMA WMV JPG FLAC M2TS*/ /*NONE*/ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, /*H263*/ { 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, diff --git a/src/mm_camcorder_platform.c b/src/mm_camcorder_platform.c index 3a82f40..d01a7db 100644 --- a/src/mm_camcorder_platform.c +++ b/src/mm_camcorder_platform.c @@ -44,7 +44,7 @@ static int __enum_conv_whitebalance[MM_CAMCORDER_WHITE_BALANCE_NUM] ; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_whitebalance = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_whitebalance = { MM_CAMCORDER_WHITE_BALANCE_NUM, __enum_conv_whitebalance, CONFIGURE_CATEGORY_CTRL_EFFECT, @@ -54,7 +54,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_whitebalance = { static int __enum_conv_colortone[MM_CAMCORDER_COLOR_TONE_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_colortone = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_colortone = { MM_CAMCORDER_COLOR_TONE_NUM, __enum_conv_colortone, CONFIGURE_CATEGORY_CTRL_EFFECT, @@ -64,7 +64,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_colortone = { static int __enum_conv_iso[MM_CAMCORDER_ISO_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_iso = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_iso = { MM_CAMCORDER_ISO_NUM, __enum_conv_iso, CONFIGURE_CATEGORY_CTRL_PHOTOGRAPH, @@ -74,7 +74,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_iso = { static int __enum_conv_prgrm[MM_CAMCORDER_SCENE_MODE_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_prgrm = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_prgrm = { MM_CAMCORDER_SCENE_MODE_NUM, __enum_conv_prgrm, CONFIGURE_CATEGORY_CTRL_PHOTOGRAPH, @@ -84,7 +84,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_prgrm = { static int __enum_conv_focus_mode[MM_CAMCORDER_FOCUS_MODE_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_focus_mode = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_focus_mode = { MM_CAMCORDER_FOCUS_MODE_NUM, __enum_conv_focus_mode, CONFIGURE_CATEGORY_CTRL_PHOTOGRAPH, @@ -94,7 +94,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_focus_mode = { static int __enum_conv_focus_type[MM_CAMCORDER_AUTO_FOCUS_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_focus_type = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_focus_type = { MM_CAMCORDER_AUTO_FOCUS_NUM, __enum_conv_focus_type, CONFIGURE_CATEGORY_CTRL_PHOTOGRAPH, @@ -104,7 +104,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_focus_type = { static int __enum_conv_ae_type[MM_CAMCORDER_AUTO_EXPOSURE_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_ae_type = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_ae_type = { MM_CAMCORDER_AUTO_EXPOSURE_NUM, __enum_conv_ae_type, CONFIGURE_CATEGORY_CTRL_PHOTOGRAPH, @@ -114,7 +114,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_ae_type = { static int __enum_conv_strobe_ctrl[MM_CAMCORDER_STROBE_CONTROL_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_strobe_ctrl = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_strobe_ctrl = { MM_CAMCORDER_STROBE_CONTROL_NUM, __enum_conv_strobe_ctrl, CONFIGURE_CATEGORY_CTRL_STROBE, @@ -124,7 +124,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_strobe_ctrl = { static int __enum_conv_strobe_mode[MM_CAMCORDER_STROBE_MODE_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_strobe_mode = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_strobe_mode = { MM_CAMCORDER_STROBE_MODE_NUM, __enum_conv_strobe_mode, CONFIGURE_CATEGORY_CTRL_STROBE, @@ -134,7 +134,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_strobe_mode = { static int __enum_conv_wdr_ctrl[MM_CAMCORDER_WDR_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_wdr_ctrl = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_wdr_ctrl = { MM_CAMCORDER_WDR_NUM, __enum_conv_wdr_ctrl, CONFIGURE_CATEGORY_CTRL_EFFECT, @@ -143,7 +143,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_wdr_ctrl = { static int __enum_conv_flip_ctrl[MM_CAMCORDER_FLIP_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_flip_ctrl = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_flip_ctrl = { MM_CAMCORDER_FLIP_NUM, __enum_conv_flip_ctrl, CONFIGURE_CATEGORY_CTRL_EFFECT, @@ -152,7 +152,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_flip_ctrl = { static int __enum_conv_rotation_ctrl[MM_CAMCORDER_ROTATION_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_rotation_ctrl = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_rotation_ctrl = { MM_CAMCORDER_ROTATION_NUM, __enum_conv_rotation_ctrl, CONFIGURE_CATEGORY_CTRL_EFFECT, @@ -162,7 +162,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_rotation_ctrl = { static int __enum_conv_ahs[MM_CAMCORDER_AHS_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_ahs = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_ahs = { MM_CAMCORDER_AHS_NUM, __enum_conv_ahs, CONFIGURE_CATEGORY_CTRL_PHOTOGRAPH, @@ -172,7 +172,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_ahs = { static int __enum_conv_video_stabilization[MM_CAMCORDER_VIDEO_STABILIZATION_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_video_stabilization = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_video_stabilization = { MM_CAMCORDER_VIDEO_STABILIZATION_NUM, __enum_conv_video_stabilization, CONFIGURE_CATEGORY_CTRL_PHOTOGRAPH, @@ -182,7 +182,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_video_stabilization = { static int __enum_conv_hdr_capture[MM_CAMCORDER_HDR_CAPTURE_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_hdr_capture = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_hdr_capture = { MM_CAMCORDER_HDR_CAPTURE_NUM, __enum_conv_hdr_capture, CONFIGURE_CATEGORY_CTRL_CAPTURE, @@ -191,7 +191,7 @@ _MMCamcorderEnumConvert _mmcamcorder_enum_conv_hdr_capture = { static int __enum_conv_detect_mode[MM_CAMCORDER_DETECT_MODE_NUM]; -_MMCamcorderEnumConvert _mmcamcorder_enum_conv_detect_mode = { +static _MMCamcorderEnumConvert _mmcamcorder_enum_conv_detect_mode = { MM_CAMCORDER_DETECT_MODE_NUM, __enum_conv_detect_mode, CONFIGURE_CATEGORY_CTRL_DETECT, -- 2.34.1