From 450d6cf321916a7123245ef9c6f197599961f022 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Thu, 13 Mar 2014 12:18:21 -0400 Subject: [PATCH] add comments to suppress false positives in intentional switch fallthroughs CIDs 1155283, 1155282, 1155281 --- src/bin/e_comp.c | 3 +++ src/bin/e_dnd.c | 1 + 2 files changed, 4 insertions(+) diff --git a/src/bin/e_comp.c b/src/bin/e_comp.c index f6e547a..7c3d9a8 100644 --- a/src/bin/e_comp.c +++ b/src/bin/e_comp.c @@ -1514,10 +1514,12 @@ e_comp_get(const void *o) gp = (E_Gadcon_Popup*)obj; obj = (void*)gp->gcc; EINA_SAFETY_ON_NULL_RETURN_VAL(obj, NULL); + /* no break */ case E_GADCON_CLIENT_TYPE: gcc = (E_Gadcon_Client*)obj; obj = (void*)gcc->gadcon; EINA_SAFETY_ON_NULL_RETURN_VAL(obj, NULL); + /* no break */ case E_GADCON_TYPE: gc = (E_Gadcon*)obj; obj = (void*)e_gadcon_zone_get(gc); @@ -1703,6 +1705,7 @@ e_comp_e_object_layer_get(const E_Object *obj) case E_GADCON_CLIENT_TYPE: gc = ((E_Gadcon_Client *)(obj))->gadcon; EINA_SAFETY_ON_NULL_RETURN_VAL(gc, 0); + /* no break */ case E_GADCON_TYPE: if (!gc) gc = (E_Gadcon *)obj; if (gc->shelf) return gc->shelf->layer; diff --git a/src/bin/e_dnd.c b/src/bin/e_dnd.c index d7efb76..bc4674b 100644 --- a/src/bin/e_dnd.c +++ b/src/bin/e_dnd.c @@ -697,6 +697,7 @@ _e_drag_win_get(const E_Drop_Handler *h, int xdnd) case E_GADCON_CLIENT_TYPE: gc = ((E_Gadcon_Client *)(h->obj))->gadcon; if (!gc) return 0; + /* no break */ case E_GADCON_TYPE: if (!gc) gc = (E_Gadcon *)h->obj; -- 2.7.4