From 450333f10a074517c167a129b92496a070ada0d4 Mon Sep 17 00:00:00 2001 From: David Kershner Date: Tue, 18 Apr 2017 16:55:11 -0400 Subject: [PATCH] staging: unisys: visorbus: remove POSTCODE in create_bus_instance Remove postcodes from create_bus_instance. If there is an error log it with dev_err. Signed-off-by: David Kershner Reviewed-by: Tim Sell Signed-off-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorbus_main.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c index 31f5d0d..269f525 100644 --- a/drivers/staging/unisys/visorbus/visorbus_main.c +++ b/drivers/staging/unisys/visorbus/visorbus_main.c @@ -995,8 +995,6 @@ create_bus_instance(struct visor_device *dev) int err; struct spar_vbus_headerinfo *hdr_info; - POSTCODE_LINUX(BUS_CREATE_ENTRY_PC, 0, 0, DIAG_SEVERITY_PRINT); - hdr_info = kzalloc(sizeof(*hdr_info), GFP_KERNEL); if (!hdr_info) return -ENOMEM; @@ -1019,11 +1017,8 @@ create_bus_instance(struct visor_device *dev) goto err_debugfs_dir; err = device_register(&dev->device); - if (err < 0) { - POSTCODE_LINUX(DEVICE_CREATE_FAILURE_PC, 0, id, - DIAG_SEVERITY_ERR); + if (err < 0) goto err_debugfs_dir; - } list_add_tail(&dev->list_all, &list_all_bus_instances); @@ -1038,6 +1033,7 @@ create_bus_instance(struct visor_device *dev) err_debugfs_dir: debugfs_remove_recursive(dev->debugfs_dir); kfree(hdr_info); + dev_err(&dev->device, "create_bus_instance failed: %d\n", err); return err; } -- 2.7.4