From 44b8cd40028f888cba315a74e0beb8e85c6ec9d1 Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Thu, 22 Sep 2011 09:08:30 -0600 Subject: [PATCH] podcheck.t: Is problem if cpan/non-cpan have same NAME If a module whose upstream is cpan has the same NAME as a module that isn't, that is a problem that should be warned about, as we shouldn't be shipping two identically named modules, even if one is not under Perl core's control. (If two cpan modules have the same name, it is a problem as well, but not anything we can do anything about, so warn only when cpan warnings are enabled.) --- t/porting/podcheck.t | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/t/porting/podcheck.t b/t/porting/podcheck.t index 3550d4f..85e4492 100644 --- a/t/porting/podcheck.t +++ b/t/porting/podcheck.t @@ -1475,7 +1475,10 @@ foreach my $filename (@files) { $checker->set_skip("$prior_filename is a README apparently for $filename"); } elsif ($filename =~ /\breadme\b/i) { $checker->set_skip("$filename is a README apparently for $prior_filename"); - } elsif (! $do_upstream_cpan && $filename =~ /^cpan/) { + } elsif (! $do_upstream_cpan + && $filename =~ /^cpan/ + && $prior_filename =~ /^cpan/) + { $checker->set_skip("CPAN is upstream for $filename"); } else { # Here have two pods with identical names that differ $prior_checker->poderror( -- 2.7.4