From 44b69b079f69017418e4f88768bc806f4a468d1a Mon Sep 17 00:00:00 2001 From: "plind44@gmail.com" Date: Fri, 20 Dec 2013 19:40:12 +0000 Subject: [PATCH] MIPS: Improve allocate locals to reduce code size. TEST= BUG= R=plind44@gmail.com Review URL: https://codereview.chromium.org/104713013 Patch from Dusan Milosavljevic . git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/mips/full-codegen-mips.cc | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc index b94f351..4225270 100644 --- a/src/mips/full-codegen-mips.cc +++ b/src/mips/full-codegen-mips.cc @@ -179,20 +179,21 @@ void FullCodeGenerator::Generate() { // Generators allocate locals, if any, in context slots. ASSERT(!info->function()->is_generator() || locals_count == 0); if (locals_count > 0) { - __ LoadRoot(at, Heap::kUndefinedValueRootIndex); // Emit a loop to initialize stack cells for locals when optimizing for // size. Otherwise, unroll the loop for maximum performance. __ LoadRoot(t5, Heap::kUndefinedValueRootIndex); - if (FLAG_optimize_for_size && locals_count > 4) { + if ((FLAG_optimize_for_size && locals_count > 4) || + !is_int16(locals_count)) { Label loop; - __ li(a2, Operand(locals_count)); + __ Subu(a2, sp, Operand(locals_count * kPointerSize)); __ bind(&loop); - __ Subu(a2, a2, 1); - __ push(t5); - __ Branch(&loop, gt, a2, Operand(zero_reg)); + __ Subu(sp, sp, Operand(kPointerSize)); + __ Branch(&loop, gt, sp, Operand(a2), USE_DELAY_SLOT); + __ sw(t5, MemOperand(sp, 0)); // Push in the delay slot. } else { + __ Subu(sp, sp, Operand(locals_count * kPointerSize)); for (int i = 0; i < locals_count; i++) { - __ push(t5); + __ sw(t5, MemOperand(sp, i * kPointerSize)); } } } -- 2.7.4