From 442d5bbd830e91683d1b3f6ca13b25611c99867e Mon Sep 17 00:00:00 2001 From: =?utf8?q?=EB=B0=95=EC=A2=85=ED=98=84/=EB=8F=99=EC=9E=91=EC=A0=9C?= =?utf8?q?=EC=96=B4Lab=28SR=29/Senior=20Engineer/=EC=82=BC=EC=84=B1?= =?utf8?q?=EC=A0=84=EC=9E=90?= Date: Fri, 11 May 2018 08:57:14 +0900 Subject: [PATCH] Build shared GFlags library (#215) The default GFlag build script dose not specify -fPIC option when building static gflags library, and thus it is impossible to use built library when building other shared libraries. This commit addresses this issue by building shared library instead of static library. Signed-off-by: Jonghyun Park --- cmake/packages/GFlagsConfig.cmake | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cmake/packages/GFlagsConfig.cmake b/cmake/packages/GFlagsConfig.cmake index b4545f5..5b6f640 100644 --- a/cmake/packages/GFlagsConfig.cmake +++ b/cmake/packages/GFlagsConfig.cmake @@ -8,10 +8,11 @@ function(_GFlags_import) if(GFlagsSource_FOUND) nncc_find_package(ExternalProjectTools REQUIRED) - # build static multi-thread library - set(GFLAGS_BUILD_STATIC_LIB On) - set(GFLAGS_BUILD_gflags_LIB On) - set(GFLAGS_BUILD_gflags_nothreads_LIB Off) + # build shared multi-threading gflag library + set(BUILD_SHARED_LIBS On) + set(BUILD_STATIC_LIBS Off) + set(BUILD_gflags_LIB On) + set(BUILD_gflags_nothreads_LIB Off) add_extdirectory(${GFLAGS_SOURCE_DIR} gflags) else(GFlagsSource_FOUND) set(GFLAGS_ROOT_DIR "" CACHE PATH "Folder contains GFlags") -- 2.7.4