From 42932e1a33ce479972ea1398a41965265d8fb06b Mon Sep 17 00:00:00 2001 From: Father Chrysostomos Date: Sat, 3 Dec 2011 09:36:38 -0800 Subject: [PATCH] Remove SvTAINT from sv_sethek MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This was copied from sv_usepvn_flags in commit 58b643af9. It is unnecessary, and probably incorrect, as heks are not tainted. Why sv_sethek used sv_usepvn_flags to begin with I don’t know, but I imagine it was for brevity’s sake. This code was ultimately derived from newSVhek, which doesn’t use sv_usepvn_flags. Because of that, and because it is now far enough removed from sv_usepvn_flags, I have removed the comment referring to it. --- sv.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sv.c b/sv.c index a2df6f5..0aebda2 100644 --- a/sv.c +++ b/sv.c @@ -4583,13 +4583,9 @@ Perl_sv_sethek(pTHX_ register SV *const sv, const HEK *const hek) return; } { - /* Emulate what sv_usepvn_flags does; it can't be called - directly, because it assumes that the data for the PV is at the - start of a malloced block */ SV_CHECK_THINKFIRST_COW_DROP(sv); SvUPGRADE(sv, SVt_PV); SvPV_set(sv,(char *)HEK_KEY(share_hek_hek(hek))); - SvTAINT(sv); SvCUR_set(sv, HEK_LEN(hek)); SvLEN_set(sv, 0); SvREADONLY_on(sv); -- 2.7.4