From 41f9dfdd76800b50f0371ccea541607fe794e9ff Mon Sep 17 00:00:00 2001 From: Kiseok Chang Date: Sat, 31 Dec 2016 20:23:10 +0900 Subject: [PATCH] Fix crash in setting-storage - fix crash when update default app loc in storage Change-Id: If37518d6f0d7aa5d384dd86380a747b93f113bbc Signed-off-by: Kiseok Chang --- setting-storage/src/setting-storage-default.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/setting-storage/src/setting-storage-default.c b/setting-storage/src/setting-storage-default.c index bdbb9056..bfe63980 100755 --- a/setting-storage/src/setting-storage-default.c +++ b/setting-storage/src/setting-storage-default.c @@ -270,10 +270,8 @@ static int storage_default_create(void *data) storage_MMC_stat); } - _create_genlist(ad, &genlist); ad->default_genlist = genlist; - /*Shared contents */ it = setting_create_Gendial_field_titleItem(genlist, &itc_group_item, @@ -340,7 +338,7 @@ static int storage_default_destroy(void *data) static int storage_default_update(void *data) { SETTING_TRACE_BEGIN; - + SettingStorage *ad = data; retv_if(data == NULL, SETTING_GENERAL_ERR_NULL_DATA_PARAMETER); @@ -349,11 +347,15 @@ static int storage_default_update(void *data) elm_genlist_realized_items_update(ad->default_genlist); if(ad->help_bt) { - ad->help_bt->keyStr = _("IDS_SM_BODY_SELECT_THE_DEFAULT_STORAGE_LOCATION_FOR_CONTENT_SHARED_VIA_BLUETOOTH_OR_WI_FI_DIRECT"); + if(ad->help_bt->keyStr) + G_FREE(ad->help_bt->keyStr); + ad->help_bt->keyStr = strdup(_("IDS_SM_BODY_SELECT_THE_DEFAULT_STORAGE_LOCATION_FOR_CONTENT_SHARED_VIA_BLUETOOTH_OR_WI_FI_DIRECT")); elm_genlist_item_update(ad->help_bt->item); } if(ad->help_installapp) { - ad->help_installapp->keyStr = _("IDS_SM_BODY_SELECT_THE_DEFAULT_LOCATION_FOR_INSTALLING_APPS_WHERE_APPS_CAN_BE_SAVED_DEPENDS_ON_THE_TYPE_OF_APP_AND_THE_AVAILABILITY_OF_THE_LOCATION"); + if(ad->help_installapp->keyStr) + G_FREE(ad->help_installapp->keyStr); + ad->help_installapp->keyStr = strdup(_("IDS_SM_BODY_SELECT_THE_DEFAULT_LOCATION_FOR_INSTALLING_APPS_WHERE_APPS_CAN_BE_SAVED_DEPENDS_ON_THE_TYPE_OF_APP_AND_THE_AVAILABILITY_OF_THE_LOCATION")); elm_genlist_item_update(ad->help_installapp->item); } -- 2.34.1