From 41e6cef6889ab14a77a95fab0b1107dc98a431a8 Mon Sep 17 00:00:00 2001
From: seoz <seoz@7cbeb6ba-43b4-40fd-8cce-4c39aea84d33>
Date: Tue, 20 Mar 2012 05:44:18 +0000
Subject: [PATCH] elm genlist: Refactoring. Create spacer object only when it
 is needed.

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@69518 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33
---
 src/lib/elm_genlist.c | 34 +++++++++++++++++++++++-----------
 1 file changed, 23 insertions(+), 11 deletions(-)

diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index 288625a..95269de 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -1576,8 +1576,11 @@ _item_cache_add(Elm_Gen_Item *it)
      {
         evas_object_del(VIEW(it));
         VIEW(it) = NULL;
-        evas_object_del(it->spacer);
-        it->spacer = NULL;
+        if (it->spacer)
+          {
+             evas_object_del(it->spacer);
+             it->spacer = NULL;
+          }
         evas_event_thaw(evas_object_evas_get(it->wd->obj));
         evas_event_thaw_eval(evas_object_evas_get(it->wd->obj));
         return;
@@ -2023,19 +2026,25 @@ _item_realize(Elm_Gen_Item *it,
 
         edje_object_mirrored_set(VIEW(it),
                                  elm_widget_mirrored_get(WIDGET(it)));
-        it->spacer =
-          evas_object_rectangle_add(evas_object_evas_get(WIDGET(it)));
-        evas_object_color_set(it->spacer, 0, 0, 0, 0);
-        elm_widget_sub_object_add(WIDGET(it), it->spacer);
      }
 
    _elm_genlist_item_odd_even_update(it);
 
    treesize = edje_object_data_get(VIEW(it), "treesize");
    if (treesize) tsize = atoi(treesize);
-   evas_object_size_hint_min_set(it->spacer,
-                                 (it->item->expanded_depth * tsize) * _elm_config->scale, 1);
-   edje_object_part_swallow(VIEW(it), "elm.swallow.pad", it->spacer);
+   if (!it->spacer && treesize)
+     {
+        it->spacer =
+          evas_object_rectangle_add(evas_object_evas_get(WIDGET(it)));
+        evas_object_color_set(it->spacer, 0, 0, 0, 0);
+        elm_widget_sub_object_add(WIDGET(it), it->spacer);
+     }
+   if (it->spacer)
+     {
+        evas_object_size_hint_min_set(it->spacer,
+                                      (it->item->expanded_depth * tsize) * _elm_config->scale, 1);
+        edje_object_part_swallow(VIEW(it), "elm.swallow.pad", it->spacer);
+     }
    if (!calc)
      {
         edje_object_signal_callback_add(VIEW(it),
@@ -2169,8 +2178,11 @@ _item_unrealize_cb(Elm_Gen_Item *it)
      {
         evas_object_del(VIEW(it));
         VIEW(it) = NULL;
-        evas_object_del(it->spacer);
-        it->spacer = NULL;
+        if (it->spacer)
+          {
+             evas_object_del(it->spacer);
+             it->spacer = NULL;
+          }
      }
    else
      {
-- 
2.7.4