From 4154baedb1069815194f254101de1557fb6ccea5 Mon Sep 17 00:00:00 2001 From: Matthew Waters Date: Wed, 11 Mar 2020 22:39:35 +1100 Subject: [PATCH] basetransform: allow not passthrough if generate_output is implemented This allows an element to not require implementing transform or transform_ip. --- libs/gst/base/gstbasetransform.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libs/gst/base/gstbasetransform.c b/libs/gst/base/gstbasetransform.c index 3c74c4b5ce..4164bd7ac7 100644 --- a/libs/gst/base/gstbasetransform.c +++ b/libs/gst/base/gstbasetransform.c @@ -2554,7 +2554,7 @@ gst_base_transform_src_activate_mode (GstPad * pad, GstObject * parent, * useful for filters that do not care about negotiation. * * Always %TRUE for filters which don't implement either a transform - * or transform_ip method. + * or transform_ip or generate_output method. * * MT safe. */ @@ -2570,7 +2570,8 @@ gst_base_transform_set_passthrough (GstBaseTransform * trans, GST_OBJECT_LOCK (trans); if (!passthrough) { - if (bclass->transform_ip || bclass->transform) + if (bclass->transform_ip || bclass->transform || (bclass->generate_output + && bclass->generate_output != default_generate_output)) trans->priv->passthrough = FALSE; } else { trans->priv->passthrough = TRUE; -- 2.34.1