From 40bed64ff0f2dc842f01a0e8ad85c0cec9fab4b5 Mon Sep 17 00:00:00 2001 From: fmalita Date: Mon, 1 Feb 2016 09:19:49 -0800 Subject: [PATCH] SkPictureShader cleanup Minor cleanup following http://crrev.com/1405103003. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1652943002 Review URL: https://codereview.chromium.org/1652943002 --- src/core/SkPictureShader.cpp | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/core/SkPictureShader.cpp b/src/core/SkPictureShader.cpp index 82d6096..44f6ef1 100644 --- a/src/core/SkPictureShader.cpp +++ b/src/core/SkPictureShader.cpp @@ -11,7 +11,6 @@ #include "SkBitmapProcShader.h" #include "SkCanvas.h" #include "SkImage.h" -#include "SkImageGenerator.h" #include "SkMatrixUtils.h" #include "SkPicture.h" #include "SkReadBuffer.h" @@ -220,16 +219,8 @@ SkShader* SkPictureShader::refBitmapShader(const SkMatrix& viewMatrix, const SkM tileMatrix.setRectToRect(fTile, SkRect::MakeIWH(tileSize.width(), tileSize.height()), SkMatrix::kFill_ScaleToFit); - SkAutoTDelete tileGenerator( - SkImageGenerator::NewFromPicture(tileSize, fPicture, &tileMatrix, nullptr)); - if (!tileGenerator) { - return nullptr; - } - - // Grab this before the generator goes poof! - const SkImageInfo tileInfo = tileGenerator->getInfo(); - - SkAutoTUnref tileImage(SkImage::NewFromGenerator(tileGenerator.detach())); + SkAutoTUnref tileImage( + SkImage::NewFromPicture(fPicture, tileSize, &tileMatrix, nullptr)); if (!tileImage) { return nullptr; } @@ -238,6 +229,7 @@ SkShader* SkPictureShader::refBitmapShader(const SkMatrix& viewMatrix, const SkM shaderMatrix.preScale(1 / tileScale.width(), 1 / tileScale.height()); tileShader.reset(tileImage->newShader(fTmx, fTmy, &shaderMatrix)); + const SkImageInfo tileInfo = SkImageInfo::MakeN32Premul(tileSize); SkResourceCache::Add(new BitmapShaderRec(key, tileShader.get(), tileInfo.getSafeSize(tileInfo.minRowBytes()))); } -- 2.7.4