From 40903bad468b71391257d56f33a67f3b5fa08f00 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Sun, 1 Jan 2023 10:01:21 -0500 Subject: [PATCH] llvm-reduce: Fix missing newline after error message Fixes missing test coverage for the failed to execute case. However, this test fails to verify the newline is printed. I can't figure out how to get FileCheck to match the trailing newline. --- llvm/test/tools/llvm-reduce/fail-execute-test.test | 3 +++ llvm/tools/llvm-reduce/TestRunner.cpp | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 llvm/test/tools/llvm-reduce/fail-execute-test.test diff --git a/llvm/test/tools/llvm-reduce/fail-execute-test.test b/llvm/test/tools/llvm-reduce/fail-execute-test.test new file mode 100644 index 0000000..badf376 --- /dev/null +++ b/llvm/test/tools/llvm-reduce/fail-execute-test.test @@ -0,0 +1,3 @@ +# RUN: not llvm-reduce --test=%s.NotAFileInTestingDir %p/Inputs/test-output-format.ll 2>&1 | FileCheck -DFILENAME=%s.NotAFileInTestingDir --strict-whitespace %s + +# CHECK: Error running interesting-ness test: Executable "[[FILENAME]]" doesn't exist!{{$}} \ No newline at end of file diff --git a/llvm/tools/llvm-reduce/TestRunner.cpp b/llvm/tools/llvm-reduce/TestRunner.cpp index fe905b3..058664d 100644 --- a/llvm/tools/llvm-reduce/TestRunner.cpp +++ b/llvm/tools/llvm-reduce/TestRunner.cpp @@ -57,7 +57,7 @@ int TestRunner::run(StringRef Filename) const { Error E = make_error("Error running interesting-ness test: " + ErrMsg, inconvertibleErrorCode()); - errs() << toString(std::move(E)); + errs() << toString(std::move(E)) << '\n'; exit(1); } -- 2.7.4