From 408b272a006a32b4b57ea56bd50f738bea4b5054 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Fri, 12 May 2017 13:18:07 +0000 Subject: [PATCH] [Hexagon] Make sure to pass empty struct arguments with nontrivial ctors Thanks to Richard Smith for the suggested fix. This fixes llvm.org/PR33009 llvm-svn: 302895 --- clang/lib/CodeGen/TargetInfo.cpp | 6 +++--- clang/test/CodeGenCXX/array-default-argument.cpp | 4 ---- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/clang/lib/CodeGen/TargetInfo.cpp b/clang/lib/CodeGen/TargetInfo.cpp index 33d6a6f..18367d1 100644 --- a/clang/lib/CodeGen/TargetInfo.cpp +++ b/clang/lib/CodeGen/TargetInfo.cpp @@ -7043,13 +7043,13 @@ ABIArgInfo HexagonABIInfo::classifyArgumentType(QualType Ty) const { ABIArgInfo::getExtend() : ABIArgInfo::getDirect()); } + if (CGCXXABI::RecordArgABI RAA = getRecordArgABI(Ty, getCXXABI())) + return getNaturalAlignIndirect(Ty, RAA == CGCXXABI::RAA_DirectInMemory); + // Ignore empty records. if (isEmptyRecord(getContext(), Ty, true)) return ABIArgInfo::getIgnore(); - if (CGCXXABI::RecordArgABI RAA = getRecordArgABI(Ty, getCXXABI())) - return getNaturalAlignIndirect(Ty, RAA == CGCXXABI::RAA_DirectInMemory); - uint64_t Size = getContext().getTypeSize(Ty); if (Size > 64) return getNaturalAlignIndirect(Ty, /*ByVal=*/true); diff --git a/clang/test/CodeGenCXX/array-default-argument.cpp b/clang/test/CodeGenCXX/array-default-argument.cpp index a215c8f..a07e3908 100644 --- a/clang/test/CodeGenCXX/array-default-argument.cpp +++ b/clang/test/CodeGenCXX/array-default-argument.cpp @@ -1,10 +1,6 @@ // RUN: %clang_cc1 -emit-llvm -o - %s -triple %itanium_abi_triple | FileCheck %s // RUN: %clang_cc1 -emit-llvm -o - %s -triple %itanium_abi_triple -std=c++98 -fexceptions -fcxx-exceptions | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-EH -// Hexagon calling convention lowering is horribly broken and fails to pass A -// object to B constructor at all! -// XFAIL: hexagon - struct A { A(); ~A(); -- 2.7.4