From 405b2bb79c702c13b248e217bf330c9f9e25ca48 Mon Sep 17 00:00:00 2001 From: Konstantin Seurer Date: Sun, 15 May 2022 12:46:11 +0200 Subject: [PATCH] radv: Use radv_fill_buffer for accel struct builds It turns out, that the fuchsia sort may actually perform clears with size < 16 which hits an assert in radv_fill_buffer_shader. This fixes random crashes in Control. Fixes: be57b08 ("radv: Build accaleration structures using LBVH") Signed-off-by: Konstantin Seurer Reviewed-by: Bas Nieuwenhuizen Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_acceleration_structure.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_acceleration_structure.c b/src/amd/vulkan/radv_acceleration_structure.c index 1da4068..32d2d0c 100644 --- a/src/amd/vulkan/radv_acceleration_structure.c +++ b/src/amd/vulkan/radv_acceleration_structure.c @@ -1939,11 +1939,10 @@ radix_sort_fill_buffer(VkCommandBuffer commandBuffer, { RADV_FROM_HANDLE(radv_cmd_buffer, cmd_buffer, commandBuffer); - assert(size % 4 == 0); assert(size != VK_WHOLE_SIZE); - radv_fill_buffer_shader(cmd_buffer, buffer_info->devaddr + buffer_info->offset + offset, size, - data); + radv_fill_buffer(cmd_buffer, NULL, NULL, buffer_info->devaddr + buffer_info->offset + offset, + size, data); } VkResult -- 2.7.4