From 405a74929803f3cdc5f72d873759ee5072228c23 Mon Sep 17 00:00:00 2001 From: Zhaowei Yuan Date: Fri, 26 Aug 2016 05:54:32 +0800 Subject: [PATCH] coregl_tracepath: Copy name with the real size Memory region newitm->name is new allocated here whose content is uncertain, so the result of strlen(newitm->name) is 0 or a random number Signed-off-by: Zhaowei Yuan Change-Id: I9a08350c2f2326089101f3cc8df74077dd3dd37d --- src/modules/tracepath/coregl_tracepath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/tracepath/coregl_tracepath.c b/src/modules/tracepath/coregl_tracepath.c index 63a1cb9..f3a5a28 100644 --- a/src/modules/tracepath/coregl_tracepath.c +++ b/src/modules/tracepath/coregl_tracepath.c @@ -674,7 +674,7 @@ _get_trace_data(Trace_Data **ftd_table, size_t td_size, const char *name) } else { Trace_Data *newitm = NULL; newitm = (Trace_Data *)calloc(1, td_size); - strncpy(newitm->name, name, strlen(newitm->name)); + strncpy(newitm->name, name, strlen(name) < (sizeof(newitm->name) -1) ? strlen(name) : (sizeof(newitm->name) -1)); newitm->next = NULL; if (prev != NULL) { -- 2.7.4