From 40514a7d7a3b745ba43c2d014e54a0d78d65d957 Mon Sep 17 00:00:00 2001 From: Michael Liao Date: Thu, 16 Jan 2020 16:02:47 -0500 Subject: [PATCH] [clangd] Add workaround for GCC5 host compilers. NFC. --- clang-tools-extra/clangd/Hover.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp index cfa5e3b..ad715db 100644 --- a/clang-tools-extra/clangd/Hover.cpp +++ b/clang-tools-extra/clangd/Hover.cpp @@ -439,7 +439,13 @@ bool isLiteral(const Expr *E) { llvm::StringLiteral getNameForExpr(const Expr *E) { // FIXME: Come up with names for `special` expressions. - return "expression"; + // + // It's an known issue for GCC5, https://godbolt.org/z/Z_tbgi. Work around + // that by using explicit conversion constructor. + // + // TODO: Once GCC5 is fully retired and not the minimal requirement as stated + // in `GettingStarted`, please remove the explicit conversion constructor. + return llvm::StringLiteral("expression"); } // Generates hover info for evaluatable expressions. -- 2.7.4