From 40003af98456607f9b6bd1910424c5243eeb5d01 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Tue, 24 Jan 2023 11:55:54 +0530 Subject: [PATCH] [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC If the current calling convection CurCC is not equal to Target calling convection ToCC and current calling convention (CurCC) is equal to the default calling convention (DefaultCC), that means DefaultCC can not be equal to ToCC so the right part of the expression DefaultCC == ToCC is not needed. revelant code - if (CurCC == ToCC) return; if (CurCC != DefaultCC || DefaultCC == ToCC) return; Found by PVS-Studio - https://pvs-studio.com/en/blog/posts/cpp/1003/, N41. Differential Revision: https://reviews.llvm.org/D142338 --- clang/lib/Sema/SemaType.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/lib/Sema/SemaType.cpp b/clang/lib/Sema/SemaType.cpp index 16986f6..89d819a 100644 --- a/clang/lib/Sema/SemaType.cpp +++ b/clang/lib/Sema/SemaType.cpp @@ -7963,7 +7963,7 @@ void Sema::adjustMemberFunctionCC(QualType &T, bool IsStatic, bool IsCtorOrDtor, CallingConv DefaultCC = Context.getDefaultCallingConvention(IsVariadic, IsStatic); - if (CurCC != DefaultCC || DefaultCC == ToCC) + if (CurCC != DefaultCC) return; if (hasExplicitCallingConv(T)) -- 2.7.4