From 3fdc4896585f6e8c606b05c8352627b56af2f397 Mon Sep 17 00:00:00 2001 From: "sgjesse@chromium.org" Date: Thu, 4 Feb 2010 15:21:05 +0000 Subject: [PATCH] Fix presubmit errors. TBR=ager@chromium.org Review URL: http://codereview.chromium.org/570024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3796 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/arm/codegen-arm.cc | 2 +- src/arm/codegen-arm.h | 2 +- src/fast-codegen.h | 4 ++-- src/full-codegen.h | 2 +- src/ia32/codegen-ia32.h | 2 +- src/version.cc | 2 +- src/x64/codegen-x64.h | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/arm/codegen-arm.cc b/src/arm/codegen-arm.cc index 10c88e855..5d4298d64 100644 --- a/src/arm/codegen-arm.cc +++ b/src/arm/codegen-arm.cc @@ -225,7 +225,7 @@ void CodeGenerator::Generate(CompilationInfo* info, Mode mode) { Variable* par = scope()->parameter(i); Slot* slot = par->slot(); if (slot != NULL && slot->type() == Slot::CONTEXT) { - ASSERT(!scope()->is_global_scope()); // no parameters in global scope + ASSERT(!scope()->is_global_scope()); // No params in global scope. __ ldr(r1, frame_->ParameterAt(i)); // Loads r2 with context; used below in RecordWrite. __ str(r1, SlotOperand(slot, r2)); diff --git a/src/arm/codegen-arm.h b/src/arm/codegen-arm.h index 462af1ed2..6eb7c964d 100644 --- a/src/arm/codegen-arm.h +++ b/src/arm/codegen-arm.h @@ -208,7 +208,7 @@ class CodeGenerator: public AstVisitor { private: // Construction/Destruction - CodeGenerator(MacroAssembler* masm); + explicit CodeGenerator(MacroAssembler* masm); // Accessors inline bool is_eval(); diff --git a/src/fast-codegen.h b/src/fast-codegen.h index 8fae81f8b..0776571a2 100644 --- a/src/fast-codegen.h +++ b/src/fast-codegen.h @@ -42,7 +42,7 @@ class FastCodeGenSyntaxChecker: public AstVisitor { : info_(NULL), has_supported_syntax_(true) { } - void Check(CompilationInfo* info); + void Check(CompilationInfo* info); CompilationInfo* info() { return info_; } bool has_supported_syntax() { return has_supported_syntax_; } @@ -65,7 +65,7 @@ class FastCodeGenSyntaxChecker: public AstVisitor { class FastCodeGenerator: public AstVisitor { public: - FastCodeGenerator(MacroAssembler* masm) : masm_(masm), info_(NULL) {} + explicit FastCodeGenerator(MacroAssembler* masm) : masm_(masm), info_(NULL) {} static Handle MakeCode(CompilationInfo* info); diff --git a/src/full-codegen.h b/src/full-codegen.h index 384588b47..96d0f3e7e 100644 --- a/src/full-codegen.h +++ b/src/full-codegen.h @@ -68,7 +68,7 @@ class FullCodeGenerator: public AstVisitor { SECONDARY }; - FullCodeGenerator(MacroAssembler* masm) + explicit FullCodeGenerator(MacroAssembler* masm) : masm_(masm), info_(NULL), nesting_stack_(NULL), diff --git a/src/ia32/codegen-ia32.h b/src/ia32/codegen-ia32.h index ee009f4b6..296afb9bf 100644 --- a/src/ia32/codegen-ia32.h +++ b/src/ia32/codegen-ia32.h @@ -348,7 +348,7 @@ class CodeGenerator: public AstVisitor { private: // Construction/Destruction - CodeGenerator(MacroAssembler* masm); + explicit CodeGenerator(MacroAssembler* masm); // Accessors inline bool is_eval(); diff --git a/src/version.cc b/src/version.cc index aea1a3a31..a20086162 100644 --- a/src/version.cc +++ b/src/version.cc @@ -34,7 +34,7 @@ // cannot be changed without changing the SCons build script. #define MAJOR_VERSION 2 #define MINOR_VERSION 1 -#define BUILD_NUMBER 1 +#define BUILD_NUMBER 1 #define PATCH_LEVEL 0 #define CANDIDATE_VERSION true diff --git a/src/x64/codegen-x64.h b/src/x64/codegen-x64.h index 4bc3454ad..8fbbe5a65 100644 --- a/src/x64/codegen-x64.h +++ b/src/x64/codegen-x64.h @@ -348,7 +348,7 @@ class CodeGenerator: public AstVisitor { private: // Construction/Destruction - CodeGenerator(MacroAssembler* masm); + explicit CodeGenerator(MacroAssembler* masm); // Accessors inline bool is_eval(); -- 2.34.1