From 3fbbcf473a59df74a0b5d9ee343169f778fbd054 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Fri, 3 Aug 2018 19:15:30 +0200 Subject: [PATCH] [gdb/testsuite] Fix regexp in py-rbreak.exp This fails for me on openSUSE leap 15.0: ... FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints is 11 ... The rbreak "" command expects 11 breaks, but I see two extra for __libc_csu_fini and __libc_csu_init: ... Breakpoint 13 at 0x4005b0: file elf-init.c, line 106.^M Breakpoint 14 at 0x400540: file elf-init.c, line 68.^M ... This patch fixes the failing test by excluding functions starting with an underscore. Tested on x86_64-linux. 2018-08-04 Tom de Vries * gdb.python/py-rbreak.exp: Fix rbreak regexp. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.python/py-rbreak.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 4f4d8a2..00c8d0a 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-08-04 Tom de Vries + + * gdb.python/py-rbreak.exp: Fix rbreak regexp. + 2018-08-02 Tom Tromey PR symtab/16842. diff --git a/gdb/testsuite/gdb.python/py-rbreak.exp b/gdb/testsuite/gdb.python/py-rbreak.exp index 97ebd79..8e68402 100644 --- a/gdb/testsuite/gdb.python/py-rbreak.exp +++ b/gdb/testsuite/gdb.python/py-rbreak.exp @@ -33,7 +33,7 @@ if ![runto_main] then { } gdb_test_no_output "nosharedlibrary" -gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"\",minsyms=False)" \ +gdb_py_test_silent_cmd "py sl = gdb.rbreak(\"^\[^_\]\",minsyms=False)" \ "get all function breakpoints" 0 gdb_test "py print(len(sl))" "11" \ "check number of returned breakpoints is 11" -- 2.7.4