From 3fa964bf53e3faa840e7832b4b9f1a903844168b Mon Sep 17 00:00:00 2001 From: "mstarzinger@chromium.org" Date: Fri, 16 Aug 2013 19:52:29 +0000 Subject: [PATCH] Remove check for empty handle for CodeGenerator::MakeCodeEpilogue. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/22840002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16209 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/codegen.cc | 8 +++----- src/full-codegen.cc | 14 +++++--------- src/lithium.cc | 10 ++++------ 3 files changed, 12 insertions(+), 20 deletions(-) diff --git a/src/codegen.cc b/src/codegen.cc index 2031b32..e988810 100644 --- a/src/codegen.cc +++ b/src/codegen.cc @@ -114,11 +114,9 @@ Handle CodeGenerator::MakeCodeEpilogue(MacroAssembler* masm, Handle code = isolate->factory()->NewCode(desc, flags, masm->CodeObject(), false, is_crankshafted); - if (!code.is_null()) { - isolate->counters()->total_compiled_code_size()->Increment( - code->instruction_size()); - code->set_prologue_offset(info->prologue_offset()); - } + isolate->counters()->total_compiled_code_size()->Increment( + code->instruction_size()); + code->set_prologue_offset(info->prologue_offset()); return code; } diff --git a/src/full-codegen.cc b/src/full-codegen.cc index f5539e8..8846107 100644 --- a/src/full-codegen.cc +++ b/src/full-codegen.cc @@ -350,21 +350,17 @@ bool FullCodeGenerator::MakeCode(CompilationInfo* info) { code->set_back_edge_table_offset(table_offset); code->set_back_edges_patched_for_osr(false); CodeGenerator::PrintCode(code, info); - info->SetCode(code); // May be an empty handle. + info->SetCode(code); #ifdef ENABLE_GDB_JIT_INTERFACE - if (FLAG_gdbjit && !code.is_null()) { + if (FLAG_gdbjit) { GDBJITLineInfo* lineinfo = masm.positions_recorder()->DetachGDBJITLineInfo(); - GDBJIT(RegisterDetailedLineInfo(*code, lineinfo)); } #endif - if (!code.is_null()) { - void* line_info = - masm.positions_recorder()->DetachJITHandlerData(); - LOG_CODE_EVENT(isolate, CodeEndLinePosInfoRecordEvent(*code, line_info)); - } - return !code.is_null(); + void* line_info = masm.positions_recorder()->DetachJITHandlerData(); + LOG_CODE_EVENT(isolate, CodeEndLinePosInfoRecordEvent(*code, line_info)); + return true; } diff --git a/src/lithium.cc b/src/lithium.cc index 790a218..fa837c7 100644 --- a/src/lithium.cc +++ b/src/lithium.cc @@ -461,12 +461,10 @@ Handle LChunk::Codegen() { CodeGenerator::MakeCodeEpilogue(&assembler, flags, info()); generator.FinishCode(code); code->set_is_crankshafted(true); - if (!code.is_null()) { - void* jit_handler_data = - assembler.positions_recorder()->DetachJITHandlerData(); - LOG_CODE_EVENT(info()->isolate(), - CodeEndLinePosInfoRecordEvent(*code, jit_handler_data)); - } + void* jit_handler_data = + assembler.positions_recorder()->DetachJITHandlerData(); + LOG_CODE_EVENT(info()->isolate(), + CodeEndLinePosInfoRecordEvent(*code, jit_handler_data)); CodeGenerator::PrintCode(code, info()); return code; -- 2.7.4