From 3fa82171f12a32519e3d7ce4ba16009d1ca4b9f4 Mon Sep 17 00:00:00 2001 From: Olof Johansson Date: Mon, 22 Jul 2013 11:35:47 +0200 Subject: [PATCH] cpan.bbclass: Fail unless Makefile.PL generates Makefile Makefile.PLs can exit with success without generating a Makefile, e.g. in cases of missing configure time dependencies. This is considered a best practice by cpantesters.org. See: * http://wiki.cpantesters.org/wiki/CPANAuthorNotes * http://www.nntp.perl.org/group/perl.qa/2008/08/msg11236.html (From OE-Core rev: 0a2dffefc6fbca37ce9604117cebc2f7d4abc1c6) Signed-off-by: Olof Johansson Signed-off-by: Saul Wold Signed-off-by: Richard Purdie --- meta/classes/cpan.bbclass | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass index bef9e82..7088039 100644 --- a/meta/classes/cpan.bbclass +++ b/meta/classes/cpan.bbclass @@ -18,6 +18,15 @@ export PERLHOSTLIB = "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_vers cpan_do_configure () { export PERL5LIB="${PERL_ARCHLIB}" yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL ${EXTRA_CPANFLAGS} + + # Makefile.PLs can exit with success without generating a + # Makefile, e.g. in cases of missing configure time + # dependencies. This is considered a best practice by + # cpantesters.org. See: + # * http://wiki.cpantesters.org/wiki/CPANAuthorNotes + # * http://www.nntp.perl.org/group/perl.qa/2008/08/msg11236.html + [ -e Makefile ] || bbfatal "No Makefile was generated by Makefile.PL" + if [ "${BUILD_SYS}" != "${HOST_SYS}" ]; then . ${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/config.sh # Use find since there can be a Makefile generated for each Makefile.PL -- 2.7.4