From 3f8027fb67bc4efae9959a4d75f8f37ecf0c3985 Mon Sep 17 00:00:00 2001 From: Bjorn Pettersson Date: Mon, 13 Sep 2021 10:43:38 +0200 Subject: [PATCH] [test] Update some test cases to use -passes when specifying the pipeline This updates transform test cases for ADCE AddDiscriminators AggressiveInstCombine AlignmentFromAssumptions ArgumentPromotion BDCE CalledValuePropagation DCE Reg2Mem WholeProgramDevirt to use the -passes syntax when specifying the pipeline. Given that LLVM_ENABLE_NEW_PASS_MANAGER isn't set to off (which is a deprecated feature) the updated test cases already used the new pass manager, but they were using the legacy syntax when specifying the passes to run. This patch can be seen as a step toward deprecating that interface. This patch also removes some redundant RUN lines. Here I am referring to test cases that had multiple RUN lines verifying both the legacy "-passname" syntax and the new "-passes=passname" syntax. Since we switched the default pass manager to "new PM" both RUN lines have verified the new PM version of the pass (more or less wasting time running the same test twice), unless LLVM_ENABLE_NEW_PASS_MANAGER is set to "off". It is assumed that it is enough to run these tests with the new pass manager now. Differential Revision: https://reviews.llvm.org/D108472 --- llvm/test/Transforms/ADCE/2002-01-31-UseStuckAround.ll | 2 +- llvm/test/Transforms/ADCE/2002-05-22-PHITest.ll | 2 +- llvm/test/Transforms/ADCE/2002-05-23-ZeroArgPHITest.ll | 8 ++++---- llvm/test/Transforms/ADCE/2002-05-28-Crash-distilled.ll | 4 ++-- llvm/test/Transforms/ADCE/2002-05-28-Crash.ll | 6 +++--- .../test/Transforms/ADCE/2002-07-17-AssertionFailure.ll | 2 +- llvm/test/Transforms/ADCE/2002-07-17-PHIAssertion.ll | 2 +- llvm/test/Transforms/ADCE/2002-07-29-Segfault.ll | 4 ++-- .../Transforms/ADCE/2003-01-22-PredecessorProblem.ll | 4 ++-- .../ADCE/2003-04-25-PHIPostDominateProblem.ll | 4 ++-- llvm/test/Transforms/ADCE/2003-06-11-InvalidCFG.ll | 4 ++-- llvm/test/Transforms/ADCE/2003-06-24-BadSuccessor.ll | 4 ++-- .../Transforms/ADCE/2003-06-24-BasicFunctionality.ll | 4 ++-- llvm/test/Transforms/ADCE/2003-09-10-UnwindInstFail.ll | 2 +- llvm/test/Transforms/ADCE/2003-09-15-InfLoopCrash.ll | 4 ++-- .../test/Transforms/ADCE/2004-05-04-UnreachableBlock.ll | 4 ++-- .../test/Transforms/ADCE/2005-02-17-PHI-Invoke-Crash.ll | 2 +- .../Transforms/ADCE/2017-08-21-DomTree-deletions.ll | 4 ++-- llvm/test/Transforms/ADCE/adce-salvage-dbg-value.ll | 2 +- llvm/test/Transforms/ADCE/basictest1.ll | 4 ++-- llvm/test/Transforms/ADCE/basictest2.ll | 4 ++-- .../ADCE/blocks-with-dead-term-nondeterministic.ll | 2 +- llvm/test/Transforms/ADCE/broken-loop-info.ll | 1 - llvm/test/Transforms/ADCE/dce_pure_call.ll | 2 +- llvm/test/Transforms/ADCE/dce_pure_invoke.ll | 2 +- llvm/test/Transforms/ADCE/debug-info-intrinsic.ll | 2 +- .../ADCE/delete-profiling-calls-to-constant.ll | 1 - llvm/test/Transforms/ADCE/unreachable-function.ll | 2 +- llvm/test/Transforms/ADCE/willreturn.ll | 2 +- llvm/test/Transforms/AddDiscriminators/basic.ll | 1 - llvm/test/Transforms/AddDiscriminators/call-nested.ll | 1 - llvm/test/Transforms/AddDiscriminators/call.ll | 1 - .../AddDiscriminators/dbg-declare-discriminator.ll | 1 - llvm/test/Transforms/AddDiscriminators/diamond.ll | 1 - llvm/test/Transforms/AddDiscriminators/first-only.ll | 1 - llvm/test/Transforms/AddDiscriminators/inlined.ll | 2 +- llvm/test/Transforms/AddDiscriminators/invoke.ll | 2 +- .../AddDiscriminators/memcpy-discriminator.ll | 2 +- llvm/test/Transforms/AddDiscriminators/multiple.ll | 1 - .../Transforms/AddDiscriminators/no-discriminators.ll | 1 - llvm/test/Transforms/AddDiscriminators/oneline.ll | 1 - llvm/test/Transforms/AggressiveInstCombine/funnel.ll | 2 +- .../test/Transforms/AggressiveInstCombine/masked-cmp.ll | 2 +- llvm/test/Transforms/AggressiveInstCombine/popcount.ll | 2 +- llvm/test/Transforms/AggressiveInstCombine/pr50555.ll | 2 +- llvm/test/Transforms/AggressiveInstCombine/rotate.ll | 2 +- .../test/Transforms/AggressiveInstCombine/trunc_ashr.ll | 2 +- .../AggressiveInstCombine/trunc_const_expr.ll | 1 - .../test/Transforms/AggressiveInstCombine/trunc_lshr.ll | 2 +- .../AggressiveInstCombine/trunc_multi_uses.ll | 1 - .../Transforms/AggressiveInstCombine/trunc_select.ll | 1 - .../AggressiveInstCombine/trunc_select_cmp.ll | 1 - llvm/test/Transforms/AggressiveInstCombine/trunc_shl.ll | 2 +- .../AggressiveInstCombine/trunc_unreachable_bb.ll | 1 - .../Transforms/AlignmentFromAssumptions/amdgpu-crash.ll | 1 - llvm/test/Transforms/AlignmentFromAssumptions/simple.ll | 1 - .../Transforms/AlignmentFromAssumptions/simple32.ll | 1 - .../Transforms/AlignmentFromAssumptions/start-unk.ll | 1 - .../ArgumentPromotion/2008-02-01-ReturnAttrs.ll | 2 +- .../ArgumentPromotion/2008-07-02-array-indexing.ll | 2 +- .../ArgumentPromotion/2008-09-08-CGUpdateSelfEdge.ll | 2 +- .../ArgumentPromotion/aggregate-promote-dead-gep.ll | 1 - .../Transforms/ArgumentPromotion/aggregate-promote.ll | 1 - llvm/test/Transforms/ArgumentPromotion/attrs.ll | 1 - llvm/test/Transforms/ArgumentPromotion/byval-2.ll | 1 - llvm/test/Transforms/ArgumentPromotion/byval.ll | 1 - llvm/test/Transforms/ArgumentPromotion/chained.ll | 1 - llvm/test/Transforms/ArgumentPromotion/control-flow.ll | 1 - llvm/test/Transforms/ArgumentPromotion/control-flow2.ll | 1 - llvm/test/Transforms/ArgumentPromotion/dbg.ll | 1 - .../ArgumentPromotion/dead-gep-no-promotion.ll | 2 +- llvm/test/Transforms/ArgumentPromotion/fp80.ll | 1 - llvm/test/Transforms/ArgumentPromotion/inalloca.ll | 1 - llvm/test/Transforms/ArgumentPromotion/musttail.ll | 2 +- .../Transforms/ArgumentPromotion/naked_functions.ll | 2 +- .../ArgumentPromotion/nonzero-address-spaces.ll | 2 +- llvm/test/Transforms/ArgumentPromotion/pr27568.ll | 1 - .../ArgumentPromotion/pr33641_remove_arg_dbgvalue.ll | 1 - llvm/test/Transforms/ArgumentPromotion/reserve-tbaa.ll | 1 - llvm/test/Transforms/ArgumentPromotion/sret.ll | 1 - llvm/test/Transforms/ArgumentPromotion/variadic.ll | 1 - llvm/test/Transforms/BDCE/basic.ll | 6 +++--- llvm/test/Transforms/BDCE/dbg-multipleuses.ll | 2 +- llvm/test/Transforms/BDCE/dce-pure.ll | 1 - llvm/test/Transforms/BDCE/dead-uses.ll | 2 +- llvm/test/Transforms/BDCE/dead-void-ro.ll | 2 +- llvm/test/Transforms/BDCE/intrinsics.ll | 2 +- llvm/test/Transforms/BDCE/invalidate-assumptions.ll | 2 +- llvm/test/Transforms/BDCE/order.ll | 2 +- llvm/test/Transforms/BDCE/pr26587.ll | 2 +- llvm/test/Transforms/BDCE/pr41925.ll | 2 +- llvm/test/Transforms/BDCE/sext_multi_uses.ll | 2 +- llvm/test/Transforms/BDCE/vectors-inseltpoison.ll | 2 +- llvm/test/Transforms/BDCE/vectors.ll | 2 +- llvm/test/Transforms/BDCE/willreturn.ll | 2 +- .../CalledValuePropagation/simple-arguments.ll | 2 +- .../Transforms/CalledValuePropagation/simple-memory.ll | 2 +- .../Transforms/CalledValuePropagation/simple-select.ll | 2 +- llvm/test/Transforms/DCE/basic-preservation.ll | 2 +- llvm/test/Transforms/DCE/basic.ll | 1 - llvm/test/Transforms/DCE/calls-errno.ll | 1 - llvm/test/Transforms/DCE/dbg-value-removal.ll | 1 - llvm/test/Transforms/DCE/guards.ll | 2 +- llvm/test/Transforms/DCE/int_sideeffect.ll | 2 +- llvm/test/Transforms/Reg2Mem/crash.ll | 3 +-- .../WholeProgramDevirt/bad-read-from-vtable.ll | 2 +- .../WholeProgramDevirt/branch-funnel-threshold.ll | 6 +++--- .../test/Transforms/WholeProgramDevirt/branch-funnel.ll | 8 ++++---- llvm/test/Transforms/WholeProgramDevirt/constant-arg.ll | 1 - .../WholeProgramDevirt/devirt-single-impl-check.ll | 2 +- .../devirt-single-impl-multiple-assumes.ll | 2 +- .../Transforms/WholeProgramDevirt/devirt-single-impl.ll | 2 +- .../WholeProgramDevirt/devirt-single-impl2.ll | 6 +++--- llvm/test/Transforms/WholeProgramDevirt/expand-check.ll | 2 +- .../Transforms/WholeProgramDevirt/export-nothing.ll | 2 +- .../Transforms/WholeProgramDevirt/export-single-impl.ll | 2 +- .../WholeProgramDevirt/export-uniform-ret-val.ll | 2 +- .../WholeProgramDevirt/export-unique-ret-val.ll | 2 +- .../WholeProgramDevirt/export-unsuccessful-checked.ll | 2 +- llvm/test/Transforms/WholeProgramDevirt/export-vcp.ll | 4 ++-- llvm/test/Transforms/WholeProgramDevirt/import-indir.ll | 2 +- .../WholeProgramDevirt/import-no-dominating-assume.ll | 2 +- llvm/test/Transforms/WholeProgramDevirt/import.ll | 17 ++++++++--------- .../WholeProgramDevirt/non-constant-vtable.ll | 2 +- .../Transforms/WholeProgramDevirt/pointer-vtable.ll | 2 +- llvm/test/Transforms/WholeProgramDevirt/soa-vtable.ll | 2 +- .../test/Transforms/WholeProgramDevirt/struct-vtable.ll | 2 +- .../WholeProgramDevirt/uniform-retval-invoke.ll | 2 +- .../uniform-retval-multiple-assumes.ll | 2 +- .../Transforms/WholeProgramDevirt/uniform-retval.ll | 2 +- .../unique-retval-multiple-assumes.ll | 2 +- .../WholeProgramDevirt/unique-retval-same-vtable.ll | 4 ++-- .../test/Transforms/WholeProgramDevirt/unique-retval.ll | 2 +- .../WholeProgramDevirt/vcp-accesses-memory.ll | 1 - llvm/test/Transforms/WholeProgramDevirt/vcp-decl.ll | 2 +- llvm/test/Transforms/WholeProgramDevirt/vcp-no-this.ll | 2 +- .../WholeProgramDevirt/vcp-non-constant-arg.ll | 2 +- .../Transforms/WholeProgramDevirt/vcp-too-wide-ints.ll | 2 +- .../Transforms/WholeProgramDevirt/vcp-type-mismatch.ll | 2 +- .../test/Transforms/WholeProgramDevirt/vcp-uses-this.ll | 2 +- .../WholeProgramDevirt/virtual-const-prop-begin.ll | 2 +- .../WholeProgramDevirt/virtual-const-prop-check.ll | 8 ++++---- .../WholeProgramDevirt/virtual-const-prop-end.ll | 2 +- .../virtual-const-prop-multiple-assumes.ll | 2 +- llvm/test/Transforms/WholeProgramDevirt/vtable-decl.ll | 2 +- 145 files changed, 141 insertions(+), 185 deletions(-) diff --git a/llvm/test/Transforms/ADCE/2002-01-31-UseStuckAround.ll b/llvm/test/Transforms/ADCE/2002-01-31-UseStuckAround.ll index 8910bda..3032c6f 100644 --- a/llvm/test/Transforms/ADCE/2002-01-31-UseStuckAround.ll +++ b/llvm/test/Transforms/ADCE/2002-01-31-UseStuckAround.ll @@ -1,4 +1,4 @@ -; RUN: opt < %s -adce +; RUN: opt < %s -passes=adce define i32 @"main"(i32 %argc) { br label %2 diff --git a/llvm/test/Transforms/ADCE/2002-05-22-PHITest.ll b/llvm/test/Transforms/ADCE/2002-05-22-PHITest.ll index 0095be1..20c72d9 100644 --- a/llvm/test/Transforms/ADCE/2002-05-22-PHITest.ll +++ b/llvm/test/Transforms/ADCE/2002-05-22-PHITest.ll @@ -1,6 +1,6 @@ ; It is illegal to remove BB1 because it will mess up the PHI node! ; -; RUN: opt < %s -adce -S | grep BB1 +; RUN: opt < %s -passes=adce -S | grep BB1 define i32 @test(i1 %C, i32 %A, i32 %B) { ;