From 3edfb4bbbc55640811d22518f583bdce1a03892e Mon Sep 17 00:00:00 2001 From: "svenpanne@chromium.org" Date: Thu, 20 Oct 2011 07:55:30 +0000 Subject: [PATCH] Make IsGenericDescriptor spec-conformant. When the descriptor argument is undefined, the spec is very explicit about the fact that we should return false (not true, like we did previously). I couldn't come up with a test case for this, but the old code leaves a bad feeling about corner cases, so better play safe. Review URL: http://codereview.chromium.org/8356004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/v8natives.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/v8natives.js b/src/v8natives.js index bb317dc..56da2a4 100644 --- a/src/v8natives.js +++ b/src/v8natives.js @@ -373,6 +373,7 @@ function IsDataDescriptor(desc) { // ES5 8.10.3. function IsGenericDescriptor(desc) { + if (IS_UNDEFINED(desc)) return false; return !(IsAccessorDescriptor(desc) || IsDataDescriptor(desc)); } -- 2.7.4